Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 45E3E431FB6 for ; Thu, 5 Apr 2012 19:24:40 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id L3PlHmwNuVtH for ; Thu, 5 Apr 2012 19:24:39 -0700 (PDT) Received: from dmz-mailsec-scanner-2.mit.edu (DMZ-MAILSEC-SCANNER-2.MIT.EDU [18.9.25.13]) by olra.theworths.org (Postfix) with ESMTP id B0F43431FAE for ; Thu, 5 Apr 2012 19:24:39 -0700 (PDT) X-AuditID: 1209190d-b7fbf6d0000008ba-b4-4f7e53e780e5 Received: from mailhub-auth-4.mit.edu ( [18.7.62.39]) by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP id 84.C0.02234.7E35E7F4; Thu, 5 Apr 2012 22:24:39 -0400 (EDT) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q362Oc4M010151; Thu, 5 Apr 2012 22:24:39 -0400 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q362ObRI026334 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Thu, 5 Apr 2012 22:24:38 -0400 (EDT) Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) (envelope-from ) id 1SFyqq-0004x3-S0; Thu, 05 Apr 2012 22:24:37 -0400 From: Austin Clements To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH v2 0/6] Move --no-exclude to --exclude=(true|false|flag) In-Reply-To: <1333234442-28616-1-git-send-email-markwalters1009@gmail.com> References: <1333234442-28616-1-git-send-email-markwalters1009@gmail.com> User-Agent: Notmuch/0.12+107~gf2d67c3 (http://notmuchmail.org) Emacs/23.3.1 (i486-pc-linux-gnu) Date: Thu, 05 Apr 2012 22:24:36 -0400 Message-ID: <87lim97g2j.fsf@awakening.csail.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsUixG6nrvs8uM7f4EWHkMXquTwW12/OZHZg 8tg56y67x7NVt5gDmKK4bFJSczLLUov07RK4MtqaLjIXNLFVLJ08k7WB8R1LFyMnh4SAicS1 addZIWwxiQv31rN1MXJxCAnsY5T4PWEBM4SznlHi+qzXLBDOCSaJp/t2QpUtYZSYtek42Cw2 AQ2JbfuXM4LYIgKuEk+/fWYGsYUFfCQOvf8KFucU8JL4ceUaO4gtJOApsenRZrBeUYF4iXUN 78HuYBFQlXjZv58NxOYFum9nywYmCFtQ4uTMJ2D1zAJaEjf+vWSawCgwC0lqFpLUAkamVYyy KblVurmJmTnFqcm6xcmJeXmpRbpGermZJXqpKaWbGEEhySnJu4Px3UGlQ4wCHIxKPLwnt9b6 C7EmlhVX5h5ilORgUhLlPR9U5y/El5SfUpmRWJwRX1Sak1p8iFGCg1lJhDfcAyjHm5JYWZVa lA+TkuZgURLnVdV65yckkJ5YkpqdmlqQWgSTleHgUJLgnQkyVLAoNT21Ii0zpwQhzcTBCTKc B2i4aTDI8OKCxNzizHSI/ClGRSlxXg6QhABIIqM0D64XljJeMYoDvSLMqwNSxQNMN3Ddr4AG MwENPvm1GmRwSSJCSqqB0XOVwJYtZwKOXyk9++epjYvYtdhtLzkOu77+5Faz7uLJha6cbHEa j/yK7u/sEX7bZmK68Khnxuyq//sDb/48n3dnl2r3n0vXdB5XSQc+XtdiWuc4k6HeSyXF2/Wx 6pz+aK79OzXcgo8vFJ360n3WUY6H2Tazky5n+arxtQrkz33vvTbz36/7H5RYijMSDbWYi4oT AVj7Koj0AgAA X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Apr 2012 02:24:40 -0000 On Sat, 31 Mar 2012, Mark Walters wrote: > This is version 2 of the exclude= series (version 1 is [1]). > > The main changes are the addition of some systematic notmuch-search > tests for all the exclude options, and I no longer add the > exclude=flag option to notmuch-show.c (the output was too similar to > exclude=false to be worth keeping). > > Best wishes > > Mark > > > id:"1331836925-31437-1-git-send-email-markwalters1009@gmail.com". Sorry for the slow review. Besides my fairly superficial comments, everything else LGTM. It's great to see exclude really turning into a robust feature! I had no idea the path would be this long when I wrote that original little hack. I'm thankful you're sticking with it.