Date: Tue, 12 Jul 2011 22:22:47 -0400
From: Austin Clements <amdragon@MIT.EDU>
To: Istvan Marko <notmuch@kismala.com>
Subject: Re: Slowness (search opens every email file?)
Message-ID: <20110713022247.GG25558@mit.edu>
References: <20110711190721.GA5386@compy.jasonwoof.org>
	<CAH-f9WtBHJ8bL6eWoSNrTs=jkrOYYCuWEVVPDUt_iCw0dKcZbw@mail.gmail.com>
	<20110712202459.GB15019@compy.jasonwoof.org>
	<CAH-f9WujE8s3DK1PyDGf3kdWLx2qvPx=dp7WZ-z_v8prqauvug@mail.gmail.com>
	<m3pqlfhrkk.fsf@zsu.kismala.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m3pqlfhrkk.fsf@zsu.kismala.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: Notmuch Mail <notmuch@notmuchmail.org>
Precedence: list

Quoth Istvan Marko on Jul 12 at  6:55 pm:
> Austin Clements <amdragon-3s7WtUTddSA@public.gmane.org> writes:
> 
> > Istvan, did you make any progress on this patch since the last
> > version?  I seem to recall it just needed general cleanup (code style
> > and such) and a better answer for backwards compatibility (the
> > unfortunate " " thing).
> 
> I have been using the version that encodes empty headers to " " but
> another way to handle this is to simply not set a VALUE for empty
> headers and then fall back to the original parsing method for these
> messages. Emails without from/subject/message-id headers are not very
> common so perhaps this is a good compromise.
> 
> Below is the patch without the " " hack.

Ah, clever.  I was going to suggest adding another value to indicate
the presence or absence of these Xapian values, but I like your
solution better.  The only downside I can think of is that it might
not extend to other headers if we store more header values in the
database in the future.

I'd say this patch looks good other than coding style
- Tab indentation
- /* */ comments, starting with a capital letter
- Space between function name and open paren
- Space after comma in argument lists
- Spaces around assignment operator