From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] build: check .git directory existence in srcdir (for
	out-of-tree builds)
In-Reply-To: <874mywroni.fsf@maritornes.cs.unb.ca>
References: <1399404928-15471-1-git-send-email-tomi.ollila@iki.fi>
	<874mywroni.fsf@maritornes.cs.unb.ca>
User-Agent: Notmuch/0.18.1+25~gdaf4b6f (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
Date: Sun, 06 Jul 2014 22:50:25 +0300
Message-ID: <m2fvieferi.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Sat, Jul 05 2014, David Bremner <david@tethera.net> wrote:

> Tomi Ollila <tomi.ollila@iki.fi> writes:
>
>> So that $(VERSION) and version.stamp uses the git-describe -based
>> version data instead of the content of `version' file.
>>
>> For consistency also the git commands in Makefile[.local] target
>> `verify-no-dirty-code' uses the git --git-dir=$srcdir/.git ...
>> commands (inside ifeq($(IS_GIT),yes)). Attempting to make this
>> target outside of the tree will fail in any case.
>
> This seems to work OK; I wondered if an alternate method of setting (and
> exporting) GIT_DIR from the top level makefile would work as well, and
> be less intrusive?

This looked like a good idea, and I tested it. But -- lo and behold --
the environment variables set in Makefile do not probagate to the
commands executed with $(shell ...) -- see (*) (I wrapped git(1) in a shell
script (executes env then execs real git) to verify this is still the case).

I thoght now a bit whether we'd use variable in place of ${srcdir}/.git
but IMHO is better in this way:

   - make does not have option to warn/die in case variable undefined,
     it is then just empty string so no internal error checking there

   - any human observer notices from the ${srcdir}/.git that we're not
     using git from any nonstandard place -- if there were variable one
     would have needed to dereference that to figure out this is the case.

(*) http://www.cmcrossroads.com/article/basics-getting-environment-variables-gnu-make?page=0%2C1

>
> d


Tomi