From: Jani Nikula <jani@nikula.org>
To: David Bremner <david@tethera.net>,
 Damien Cassou <damien.cassou@gmail.com>,	notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: Function to query the list of labels from a
	thread-id
In-Reply-To: <87objibex1.fsf@zancas.localnet>
References: <1351451478-11792-1-git-send-email-damien.cassou@gmail.com>
	<87390v8z52.fsf@nikula.org> <87objibex1.fsf@zancas.localnet>
User-Agent: Notmuch/0.14+76~gef5e8d1 (http://notmuchmail.org) Emacs/23.4.1
	(i686-pc-linux-gnu)
Date: Wed, 31 Oct 2012 22:48:14 +0200
Message-ID: <87obji74hd.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Wed, 31 Oct 2012, David Bremner <david@tethera.net> wrote:
> Jani Nikula <jani@nikula.org> writes:
>
>> Hi Damien, please send this patch as part of the series adding
>> notmuch-labeler. Out of context, without adding any users of the
>> function, it's a bit difficult to evaluate.
>
> For what it's worth (and I'm definitely not claiming any kind final word
> here) I did tell Damien that he was welcome to send pre-requisite
> patches in a seperate series.  Of course, if you feel like you can't
> really review what's there (or it's just too much work), that's your
> call.

I don't disagree with sending pre-requisite patches first. And I am
definitely not asking to polish all of the follow up work at once. I
should have made myself more clear about that. But I do think it would
be helpful to see what the added code will be used for. We may be able
to provide better and more productive review of the big picture, instead
of focusing on the details of the small snippet here.

BR,
Jani.