DomainKey-Signature: a=rsa-sha1; c=nofws; d=SSpaeth.de; h=from:to:subject
	:in-reply-to:references:date:message-id:mime-version:
	content-type; q=dns; s=sspaeth.de; b=B5le8+4IYFdg53fAya3npDWPGHX
	/yn2YIp0qh3qZmQBQRc5dAsKDjj9REKHhtlkGSTC3G+/93k05c54ToPJUNPR9SLY
	n4n1RU8KNBo0H1j899H0ZSCNr30jDYWiulAFNJ2cCa+HpFW5scaPzPLd16a9ypLu
	n1oGsiPmkvcVMNPI=
From: Sebastian Spaeth <Sebastian@SSpaeth.de>
To: Justus Winter <4winter@informatik.uni-hamburg.de>, notmuch@notmuchmail.org
Subject: Re: [PATCH 5/7] py3k: the basestring and unicode types are removed in
	python 3
In-Reply-To:
 <1323860305-15802-6-git-send-email-4winter@informatik.uni-hamburg.de>
References:
 <1323860305-15802-1-git-send-email-4winter@informatik.uni-hamburg.de>
	<1323860305-15802-6-git-send-email-4winter@informatik.uni-hamburg.de>
User-Agent: Notmuch/0.10+58~g935365d (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Mon, 02 Jan 2012 16:15:58 +0100
Message-ID: <87hb0ekudt.fsf@SSpaeth.de>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

Happy new year. Pushed patches 1-4 of this series so far. Looking fine,
but ugh, the below seems like a rather ugly hack in a function that is
probably called quite often.

Isn't there a more pretty variant avoiding these sys.version_info checks
all over the place?

> @@ -200,9 +201,9 @@ def _str(value):
>=20=20
>      C++ code expects strings to be well formatted and
>      unicode strings to have no null bytes."""
> -    if not isinstance(value, basestring):
> +    if not isinstance(value, basestring if sys.version_info[0] =3D=3D 2 =
else str):
>          raise TypeError("Expected str or unicode, got %s" % str(type(val=
ue)))
> -    if isinstance(value, unicode):
> +    if sys.version_info[0] =3D=3D 3 or isinstance(value, unicode):
>          return value.encode('UTF-8')
>      return value

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk8Byi4ACgkQVYX1jMgnoGK4SACfd/8d+iAeYWWFclRaKC4jfq7j
BcEAn3K/dWWTo9iumTX5NjnO4XPLBdCB
=XUSg
-----END PGP SIGNATURE-----
--=-=-=--