Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 04BC16DE1488 for ; Wed, 9 Sep 2015 16:18:42 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 3.129 X-Spam-Level: *** X-Spam-Status: No, score=3.129 tagged_above=-999 required=5 tests=[AWL=-1.305, RCVD_IN_BRBL_LASTEXT=1.644, RCVD_IN_SBL=2.596, RP_MATCHES_RCVD=-0.55, URIBL_SBL=0.644, URIBL_SBL_A=0.1] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4vhnviSwzlxz for ; Wed, 9 Sep 2015 16:18:40 -0700 (PDT) Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) by arlo.cworth.org (Postfix) with ESMTPS id DECDA6DE13D2 for ; Wed, 9 Sep 2015 16:18:39 -0700 (PDT) Received: from remotemail by yantan.tethera.net with local (Exim 4.80) (envelope-from ) id 1ZZodM-0002Fx-9f; Wed, 09 Sep 2015 20:18:32 -0300 Received: (nullmailer pid 3411 invoked by uid 1000); Wed, 09 Sep 2015 23:18:28 -0000 From: David Bremner To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH 2/2] cli/count: apply uncrustify changes In-Reply-To: <87613jpkam.fsf@zancas.localnet> References: <1441632818-22483-1-git-send-email-david@tethera.net> <1441632818-22483-2-git-send-email-david@tethera.net> <87613jpkam.fsf@zancas.localnet> User-Agent: Notmuch/0.20.2+71~gf460ad4 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Wed, 09 Sep 2015 20:18:28 -0300 Message-ID: <87613j41x7.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Sep 2015 23:18:42 -0000 David Bremner writes: > Tomi Ollila writes: > >>> >>> if (exclude == EXCLUDE_TRUE) { >>> search_exclude_tags = notmuch_config_get_search_exclude_tags >>> - (config, &search_exclude_tags_length); >>> + (config, &search_exclude_tags_length); >> >> With the first 2 uncrustify does a good job, but this last one it disagrees >> how emacs(1) indents (and how it is currently indented in other notmuch >> source files) -- I'd leave the last (3rd) change out. > > I actually think the uncrustify version is better, but I agree there is > not much point having a standard that isn't easily achievable with > emacs. After a short struggle trying to understand CC-mode indentation, > I give up. Pushed these two, amended as Tomi suggested. d