Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 00195431FBD for ; Wed, 8 Aug 2012 09:26:04 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Li4MYCA6CIre for ; Wed, 8 Aug 2012 09:26:02 -0700 (PDT) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id A9213431FAE for ; Wed, 8 Aug 2012 09:26:02 -0700 (PDT) Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) by earth-doxen-postvirus (Postfix) with ESMTP id 1E19766E013F; Wed, 8 Aug 2012 09:26:02 -0700 (PDT) X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new Received: from finestructure.net (unknown [76.89.192.57]) (Authenticated sender: jrollins) by earth-doxen-submit (Postfix) with ESMTP id BBD2E66E011F; Wed, 8 Aug 2012 09:25:52 -0700 (PDT) Received: by finestructure.net (Postfix, from userid 1000) id 70E245CF; Wed, 8 Aug 2012 09:25:52 -0700 (PDT) From: Jameson Graef Rollins To: Mark Walters , Austin Clements , Ben Gamari , notmuch@notmuchmail.org Subject: Re: [PATCH] sprinters: bugfix when NULL passed for a string. In-Reply-To: <878vdp3knf.fsf@qmul.ac.uk> References: <871ujjuu2z.fsf@gmail.com> <878vdrp4d9.fsf@qmul.ac.uk> <874noe1o0r.fsf@qmul.ac.uk> <87ipcut9r4.fsf@awakening.csail.mit.edu> <878vdp3knf.fsf@qmul.ac.uk> User-Agent: Notmuch/0.13.2+137~ge34ed71 (http://notmuchmail.org) Emacs/23.4.1 (x86_64-pc-linux-gnu) Date: Wed, 08 Aug 2012 09:25:49 -0700 Message-ID: <87obmlic4y.fsf@servo.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Aug 2012 16:26:05 -0000 --=-=-= On Wed, Aug 08 2012, Mark Walters wrote: > For the From/Date headers see http://www.ietf.org/rfc/rfc2822.txt > section 3.6 for details: > > The only required header fields are the origination date field and > the originator address field(s). All other header fields are > syntactically optional. > > and origination date field means a Date: header, and originator > address field means a From: header. However, I don't think an empty > string is valid for either of these so we can't sensibly output > something standards compliant. Thus I would go for following the > original message and omit any fields not present in it. I agree. Let's not pretend or imply something is valid when it's not. The output should reflect the actual content of the message as much as possible. jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBCAAGBQJQIpMOAAoJEO00zqvie6q8HSUP/i34k5X9+XXv9cqSgfZ+LvFE FMro051iAXijW/+Iy3jFaOgGUXM9RP8BfdJqkNea3uODO23aJ/O1NVp8W2yTTWq8 5RjHeyuGr3aIV9HrmzDFhtdnVoQejb2TceOGDm268qeYbxuuK2ons6uD/1z4vhGV m4pP+wnDLdpJvLKQzrdfRBmhG4NBAD/u4odp9+xt+qNBfAKHwoI52VIZ+1U04l76 JoAanaAkOcXVyVZiThJaI83PjFfJ2FxR4ZbS06/PlxWKmY4mg0Dtb2bTMfrhvfnX FALJorShOo/jSxVPt1o/inEVTR3ZRATAICjbJVBAk9uWizpllOzsQUN5NwUd2jN4 HLbpWfxwI8THLSXJEhjhpFH7eMPnlF6n3TJcxMBnu8PgVnGe6P/3Sf+Lr0zUmTzh CodySgieOc8g4KTK9yx9IQRhlk0piLNEnX0C4/TykY9rDvwc5CeGqRe4u+1Sqdo6 TpqNDnsr6lPJ0qDPQA3j2fzJdx5CVcjzcGj6z1EHJtPTOKGqc0iNzgplPN6EFE1l t3Oo4scFPZbQKuWoCkf/fTMbuyDF0RAU59v601/B4zdMPUaWxryISivFVIxAH648 ejqZGR+c1dzyj92lYvzstdzdFf5YqZ7pD1p2/MACM7Y8xU5pOK1I0CBjVSX/5KLj J3dD+qW+xfgXIKW/QohA =ugtb -----END PGP SIGNATURE----- --=-=-=--