Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 3D4896DE1890 for ; Sun, 13 Mar 2016 05:37:49 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.031 X-Spam-Level: X-Spam-Status: No, score=-0.031 tagged_above=-999 required=5 tests=[AWL=-0.020, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Hu-HHXfKGqeT for ; Sun, 13 Mar 2016 05:37:47 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id 343B66DE188C for ; Sun, 13 Mar 2016 05:37:47 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.84) (envelope-from ) id 1af5Hn-0005hY-Fb; Sun, 13 Mar 2016 08:38:19 -0400 Received: (nullmailer pid 16606 invoked by uid 1000); Sun, 13 Mar 2016 12:37:40 -0000 From: David Bremner To: patricktotzke@gmail.com Cc: notmuch@notmuchmail.org Subject: Re: [PATCH] use notmuch_database_open_verbose In-Reply-To: References: <1457795857-12410-1-git-send-email-patricktotzke@gmail.com> <87r3ff64sa.fsf@zancas.localnet> <87oaaj64gh.fsf@zancas.localnet> User-Agent: Notmuch/0.21+74~g6c60fb1 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Sun, 13 Mar 2016 09:37:40 -0300 Message-ID: <87lh5m5zaj.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Mar 2016 12:37:49 -0000 Patrick Totzke writes: > As far as I understand the bindings, the returned message is not needed > because the return > value of `Database._open` (line 212) contains information about the type of > error that occurred. > This is passed on two lines below if the open-call was unsuccessful. > > The docstrings for this method are not ideal (the mentioned "status" > parameter is actually called "mode") but in terms of functionality it seems > ok. The error_message parameter (potentially) contains additional information about an error. In any case, you're passing one too few arguments to n_d_open_verbose, which doesn't seem like a good idea. d