Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 935DC431E64 for ; Mon, 30 Jan 2012 01:23:45 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id taMJBTcQvqr8 for ; Mon, 30 Jan 2012 01:23:45 -0800 (PST) Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id E0336431FBC for ; Mon, 30 Jan 2012 01:23:44 -0800 (PST) Received: by wgbdt12 with SMTP id dt12so3757849wgb.2 for ; Mon, 30 Jan 2012 01:23:43 -0800 (PST) Received: by 10.180.83.72 with SMTP id o8mr26414503wiy.22.1327915423831; Mon, 30 Jan 2012 01:23:43 -0800 (PST) Received: from hotblack-desiato.hh.sledj.net (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25]) by mx.google.com with ESMTPS id l8sm50478206wiy.5.2012.01.30.01.23.41 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 30 Jan 2012 01:23:42 -0800 (PST) Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000) id BD84FA05FB; Mon, 30 Jan 2012 09:23:40 +0000 (GMT) To: David Bremner , Jani Nikula Subject: Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." In-Reply-To: <87ty3fycje.fsf@zancas.localnet> References: <87k44uprvy.fsf@praet.org> <1326532638-22068-1-git-send-email-pieter@praet.org> <87y5ssxam7.fsf@zancas.localnet> <87ty3fycje.fsf@zancas.localnet> User-Agent: Notmuch/0.11+122~g97bdcf6 (http://notmuchmail.org) Emacs/24.0.92.1 (x86_64-pc-linux-gnu) From: David Edmondson Date: Mon, 30 Jan 2012 09:23:40 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Cc: Notmuch Mail X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jan 2012 09:23:45 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sat, 28 Jan 2012 13:14:45 -0400, David Bremner wrote: > On Sat, 28 Jan 2012 14:55:22 +0200, Jani Nikula wrote: > > On Jan 28, 2012 2:41 PM, "David Bremner" wrote: > >=20 > > Sometimes someone (Dmitry?) sent patches that separated a small functio= nal > > change, and the big non-functional indentation change it caused, > > separately. Would you prefer (or tolerate ;) that style? >=20 > Hmm, that might be nicer, I'm not 100% sure. >=20 > I wouldn't say it's mandatory for a patch like this (and I'd say other > peoples views on what's easy to review are at least as important as mine > here). Each patch should be valid in the repository without any following patches (preceding are obviously okay). Incorrect indentation would disqualify a patch from being 'valid', so it shouldn't be accepted. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk8mYZwACgkQaezQq/BJZRbCnwCePQkYxeuqSJN0LN21Ryp0e7RH lq0An1fLBTPbB6O1nDTG7JemvOnXpRDY =cLDC -----END PGP SIGNATURE----- --=-=-=--