From: Jesse Rosenthal <jrosenthal@jhu.edu>
To: Carl Worth <cworth@cworth.org>, Xavier Maillard <xma@gnu.org>,
	Mark Anderson <MarkR.Anderson@amd.com>, notmuch@notmuchmail.org
Subject: Re: [notmuch] Bulk message tagging
In-Reply-To: <87fx2xfs4q.fsf@yoom.home.cworth.org>
References: <m2tyrrkf32.fsf@deb.maillard.im> <87sk7b30tg.fsf@jhu.edu>
	<m2bpdye86s.fsf@deb.maillard.im>
	<3wdmxxg4axm.fsf@testarossa.amd.com>
	<m2wrwf76n3.fsf@deb.maillard.im>
	<87fx2xfs4q.fsf@yoom.home.cworth.org>
Date: Thu, 15 Apr 2010 16:04:38 -0400
Message-ID: <87tyrcwkh5.fsf@jhu.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list


On Wed, 14 Apr 2010 17:59:01 -0700, Carl Worth <cworth@cworth.org> wrote:
> We could fix all[*] the bugs of "*" by changing it to simply call the
> new region-based tagging function. The only concern I have with that is
> that it might be significantly slower, (it will execute N "notmuch tag"
> commands to tag the N threads in the current buffer, rather than just
> one "notmuch tag" command with the same search).

Not quite true: the region command only executes one "notmuch tag"
command over "id:X or id:Y or id:Z or ...". 

It does have to iterate over the messages to get the ids, and again to
set the tags (i.e., write them in the buffer), but that's all in the
buffer -- there's only one xapian command. 

And anything that updates the buffer in real time would have to iterate
through the messages to rewrite the tag representation, so I'm not sure
if there's that much being lost here.

That being said, there might be a bit of redundancy (one save-excursion
trip through the buffer to get the tags for completion, another to get
the ids, and one more to rewrite the parenthetical tag
representation). But I'm not quite sure how to avoid that, or how
expensive it actually is.

Best,
Jesse