Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 2B178429E5F for ; Wed, 29 Jun 2011 00:35:00 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.699 X-Spam-Level: X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JCAdjm0ovK9o for ; Wed, 29 Jun 2011 00:34:59 -0700 (PDT) Received: from mail-qy0-f181.google.com (mail-qy0-f181.google.com [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 9BD51429E5B for ; Wed, 29 Jun 2011 00:34:59 -0700 (PDT) Received: by qyk9 with SMTP id 9so626357qyk.5 for ; Wed, 29 Jun 2011 00:34:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=mpMO3OKuarI4kVVg29vq4iT6gfAKloRMnxzbY2Sq/rk=; b=RMQE1tqXcmpeffRmbo0bouKMdNZPEb/PQCHwCd1iyELbjd/IpRFPtUjvTrUOP/oZlh 1GajUIUSdY5l6OBdHcU2HlrDQ5pJWIogoSJFH8wpKQGwTfL6TF+nskwlXAsp66GuqwLU 1SUffUD0Lb0+TSYXFYyxPN5H/Z8T+LvZ2KslQ= MIME-Version: 1.0 Received: by 10.229.2.89 with SMTP id 25mr335790qci.39.1309332898837; Wed, 29 Jun 2011 00:34:58 -0700 (PDT) Sender: amdragon@gmail.com Received: by 10.229.249.193 with HTTP; Wed, 29 Jun 2011 00:34:58 -0700 (PDT) In-Reply-To: <87r56d7as1.fsf@yoom.home.cworth.org> References: <1309236311-2162-1-git-send-email-dmitry.kurochkin@gmail.com> <1309236311-2162-10-git-send-email-dmitry.kurochkin@gmail.com> <87hb798uz7.fsf@yoom.home.cworth.org> <87wrg5wq8o.fsf@gmail.com> <87r56d7as1.fsf@yoom.home.cworth.org> Date: Wed, 29 Jun 2011 03:34:58 -0400 X-Google-Sender-Auth: kq-Gqsb4iTPxIycmxYtRjUb89xE Message-ID: Subject: Re: [PATCH 10/10] test: use emacsclient(1) for Emacs tests From: Austin Clements To: Carl Worth Content-Type: text/plain; charset=ISO-8859-1 Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2011 07:35:00 -0000 On Tue, Jun 28, 2011 at 8:15 PM, Carl Worth wrote: > That means that if the emacs_deliver_message code is fast enough, (less > than 1 second), and if the test suite is being run on a lame filesystem > without sub-second timestamp granularity (including ext3fs) that the > "notmuch new" invocation will not see the mail[*]. Or, really, any file system, since notmuch doesn't currently take advantage of sub-second mtimes. > [*] And, yes, this does mean that there are race conditions under which > mail can be delivered and notmuch won't see it, (unless subsequent mails > are delivered to the same directory). Austin has a plan to fix the use > of the mtime timestamp in notmuch, (never storing the current mtime in > the database if it's the same as the current time), that should > hopefully close this race window. Posted.