DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=from:to:subject:in-reply-to:references:user-agent:date:message-id
	:mime-version:content-type;
	b=iPEjwdbJM0f6XpD00QznRReh3EL0DTGoheNuAU2N0s6NeLKM0rWHDMZEXHhOOgakhJ
	Z+BAyptdx8i/n4nixSr9pFOVf8fQqqkLfZ1PPvtIsHACiQ2MqPzgPUhw/g7Fhb0/NJO6
	BqnausccwdOLG7xeXBMiae/ATShQV5VQEA0L0=
From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Carl Worth <cworth@cworth.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 3/5] Fix hiding a message while some citations are shown
	in notmuch-show view.
In-Reply-To: <87k4ddcfnx.fsf@yoom.home.cworth.org>
References: <1306361416-5019-1-git-send-email-dmitry.kurochkin@gmail.com>
	<1306361416-5019-4-git-send-email-dmitry.kurochkin@gmail.com>
	<87oc2qa07g.fsf@yoom.home.cworth.org> <87k4depfyj.fsf@gmail.com>
	<87lixu9z5b.fsf@yoom.home.cworth.org> <87hb8ipeb0.fsf@gmail.com>
	<87ipsy9sue.fsf@yoom.home.cworth.org> <87d3j5pxk5.fsf@gmail.com>
	<87k4ddcfnx.fsf@yoom.home.cworth.org>
User-Agent: Notmuch/0.5-216-g0104e23 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Fri, 27 May 2011 01:42:22 +0400
Message-ID: <877h9dp29t.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Thu, 26 May 2011 14:31:30 -0700, Carl Worth <cworth@cworth.org> wrote:
> On Thu, 26 May 2011 14:26:34 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > It is called indirectly.  What is the best way to fix it?  I imagine
> > that we can replace `isearch-range-invisible' function with another one,
> > which would call the fixed function if some special variable is set, or
> > if we are searching in a notmuch-show view.  Otherwise it would call the
> > original function.
> 
> I'm not sure what the best approach would be. I'd like to be a good
> "emacs citizen" but I don't know what the best way to do that is here.
> 

Agreed on being a good "emacs citizen".

> If we can predict what the first emacs release will be that contains the
> fix, then we could restrict our kludge here to older, unfixed
> emacs. That would help avoid some problems with "bad citizenship here".
> 
> I'm willing to take whatever you this is best here.
> 

I have just send two more patches to this thread.  One with new tests.
Another with a workaround for the bug.  The workaround should not break
anything since it affects only notmuch-show mode.

Regards,
  Dmitry

> -Carl
> 
> -- 
> carl.d.worth@intel.com
Non-text part: application/pgp-signature