From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Amadeusz =?utf-8?B?xbtvxYJub3dza2k=?= <aidecoe@aidecoe.name>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH] Build symbol-test with make instead of hardcoding in
	symbol-hiding.
In-Reply-To: <1322342060-967-1-git-send-email-aidecoe@aidecoe.name>
References: <1322341843-sup-9963@raeviah>
	<1322342060-967-1-git-send-email-aidecoe@aidecoe.name>
User-Agent: Notmuch/0.10+25~g1a9cfbd (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Sun, 27 Nov 2011 22:25:09 +0400
Message-ID: <87vcq5e83e.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list

On Sat, 26 Nov 2011 22:14:20 +0100, Amadeusz =C5=BBo=C5=82nowski <aidecoe@a=
idecoe.name> wrote:
> If symbol-test is built in symbol-hiding with hardcoded g++ invokation,
> it's not so easy to pass $(srcdir) which is required to find notmuch.h
> when srcdir and builddir are separate directories.
> ---
>  test/.gitignore     |    1 +
>  test/Makefile.local |    7 +++++--
>  test/basic          |    2 +-
>  test/symbol-hiding  |    3 +--
>  4 files changed, 8 insertions(+), 5 deletions(-)
>=20
> diff --git a/test/.gitignore b/test/.gitignore
> index 9e97052..7e30e8d 100644
> --- a/test/.gitignore
> +++ b/test/.gitignore
> @@ -1,4 +1,5 @@
>  test-results
>  corpus.mail
>  smtp-dummy
> +symbol-test
>  tmp.*
> diff --git a/test/Makefile.local b/test/Makefile.local
> index 9b3308a..646779e 100644
> --- a/test/Makefile.local
> +++ b/test/Makefile.local
> @@ -11,10 +11,13 @@ smtp_dummy_modules =3D $(smtp_dummy_srcs:.c=3D.o)
>  $(dir)/smtp-dummy: $(smtp_dummy_modules)
>  	$(call quiet,CC) $^ -o $@
>=20=20
> +$(dir)/symbol-test: $(dir)/symbol-test.o
> +	$(call quiet,CC) $^ -o $@ -Llib -lnotmuch -lxapian
> +
>  .PHONY: test check
> -test:	all $(dir)/smtp-dummy
> +test:	all $(dir)/smtp-dummy $(dir)/symbol-test
>  	@${dir}/notmuch-test $(OPTIONS)
>=20=20
>  check: test
>=20=20
> -CLEAN :=3D $(CLEAN) $(dir)/smtp-dummy $(dir)/smtp-dummy.o
> +CLEAN :=3D $(CLEAN) $(dir)/smtp-dummy $(dir)/smtp-dummy.o $(dir)/symbol-=
test $(dir)/symbol-test.o
> diff --git a/test/basic b/test/basic
> index f258d1f..4edf831 100755
> --- a/test/basic
> +++ b/test/basic
> @@ -54,7 +54,7 @@ test_begin_subtest 'Ensure that all available tests wil=
l be run by notmuch-test'
>  eval $(sed -n -e '/^TESTS=3D"$/,/^"$/p' $TEST_DIRECTORY/notmuch-test)
>  tests_in_suite=3D$(for i in $TESTS; do echo $i; done | sort)
>  available=3D$(find "$TEST_DIRECTORY" -maxdepth 1 -type f -executable -pr=
intf '%f\n' | \
> -    sed -r -e "/^(aggregate-results.sh|notmuch-test|smtp-dummy|test-verb=
ose)$/d" | \
> +    sed -r -e "/^(aggregate-results.sh|notmuch-test|smtp-dummy|test-verb=
ose|symbol-test)$/d" | \

Can you please keep this list alphabetically sorted?

Regards,
  Dmitry

>      sort)
>  test_expect_equal "$tests_in_suite" "$available"
>=20=20
> diff --git a/test/symbol-hiding b/test/symbol-hiding
> index d0b31ae..f67b653 100755
> --- a/test/symbol-hiding
> +++ b/test/symbol-hiding
> @@ -12,13 +12,12 @@ test_description=3D'exception symbol hiding'
>  . ./test-lib.sh
>=20=20
>  run_test(){
> -    result=3D$(LD_LIBRARY_PATH=3D$TEST_DIRECTORY/../lib ./symbol-test 2>=
&1)
> +    result=3D$(LD_LIBRARY_PATH=3D$TEST_DIRECTORY/../lib $TEST_DIRECTORY/=
symbol-test 2>&1)
>  }
>=20=20
>  output=3D"A Xapian exception occurred opening database: Couldn't stat 'f=
akedb/.notmuch/xapian'
>  caught No chert database found at path \`./nonexistant'"
>=20=20
> -g++ -o symbol-test -I$TEST_DIRECTORY/../lib $TEST_DIRECTORY/symbol-test.=
cc -L$TEST_DIRECTORY/../lib -lnotmuch -lxapian
>  mkdir -p fakedb/.notmuch
>  test_expect_success 'running test' run_test
>  test_begin_subtest 'checking output'
> --=20
> 1.7.8.rc3
>=20
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch