From: Tomi Ollila <tomi.ollila@iki.fi>
To: Michal Nazarewicz <mina86@mina86.com>, Jani Nikula <jani@nikula.org>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH v3 2/9] parse-time-string: add a date/time parser to
	notmuch
In-Reply-To: <xa1tvcfidvpe.fsf@mina86.com>
References: <cover.1347484177.git.jani@nikula.org>
	<89741ec9a9687fca8b30aa1a4877392d355dd3ce.1347484177.git.jani@nikula.org>
	<xa1tvcfidvpe.fsf@mina86.com>
User-Agent: Notmuch/0.13.2+162~ged38330 (http://notmuchmail.org) Emacs/24.2.1
	(x86_64-unknown-linux-gnu)
Date: Thu, 13 Sep 2012 15:48:24 +0300
Message-ID: <m2oblajdgn.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list

On Thu, Sep 13 2012, Michal Nazarewicz <mina86@mina86.com> wrote:

> On Wed, Sep 12 2012, Jani Nikula <jani@nikula.org> wrote:
>> Add a date/time parser to notmuch, to be used for adding date range
>> query support for notmuch lib later on. Add the parser to a directory
>> of its own to make it independent of the rest of the notmuch code
>> base.
>>
>> Signed-off-by: Jani Nikula <jani@nikula.org>
>
> Have you consider doing the same in bison?  I consider the code totally
> unreadable and unmaintainable.

Well, I don't find this code 'unreadable', perhaps it depends how you
define it ;)

This functionality has been in 'work-in-progress' for a long time. I think
the interface how this (separate library) is hooked to notmuch is sane.
Also, my 'hunch' is that this is maintainable enough (and Jani will do
all expected 'zero' maintenaince issues that will appear). If, in the
future, there is enough desire for internationalization then Someone(TM)
may see the way to do it.

But, for the time being I applause the hard work Jani has put into=20
this library and as it is much better what we have now (i.e. nothing)
I am going to start testing this (and drop my current wrapper which
I've been using to search using relative times)...

It might be interesting to see this implemented in Bison but just for
the sake of it I don't think it is worth of it. Maybe, someday...,
Someone Else(tm) does that. The interface should allow to make drop-in
replacement for this parser...

Tomi


>
> --=20
> Best regards,                                         _     _
> .o. | Liege of Serenely Enlightened Majesty of      o' \,=3D./ `o
> ..o | Computer Science,  Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz =
   (o o)
> ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--_______=
________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch