Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 965104196F0 for ; Wed, 9 Jun 2010 10:50:26 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.89 X-Spam-Level: X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lMz9hS-T33-C; Wed, 9 Jun 2010 10:50:16 -0700 (PDT) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 535A3431FC1; Wed, 9 Jun 2010 10:50:16 -0700 (PDT) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id 03D22568E39; Wed, 9 Jun 2010 10:50:16 -0700 (PDT) From: Carl Worth To: Jameson Rollins , Notmuch Mail Subject: Re: [PATCH] remove message archiving from show-advance-and-archive In-Reply-To: <87zkz4xnf4.fsf@servo.finestructure.net> References: <87zkz4xnf4.fsf@servo.finestructure.net> User-Agent: Notmuch/0.3.1-61-ge870437 (http://notmuchmail.org) Emacs/23.1.1 (i486-pc-linux-gnu) Date: Wed, 09 Jun 2010 10:50:15 -0700 Message-ID: <871vcghz8o.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2010 17:50:26 -0000 --=-=-= On Wed, 9 Jun 2010 10:49:43 -0400, Jameson Rollins wrote: > The function to advance through threads with the space bar is useful. > However, the current implementation also archives messages. The idea > of archiving a message should not be intertwined with the processes of > advancing through messages to read them. Archiving in general should > be a separate operation that one does explicitly. This patch just > renames the advance function "notmuch-show-advance", and removes the > archiving of a thread when the end of the thread is reached. The other piece of the magic space bar that people have complained about is that it intertwines advancing among messages within one thread with advancing from one thread to the next. (And only the first operation is reversible by backspace.) I think we'll probably want to change that at the same time. Meanwhile, I'm currently working on support for piping a whole thread of messages as an mbox to a process, (mostly getting bogged down in trying to fix mbox support in git). For that, I think I want the current '|' binding to pipe the current message and then a new binding ("M-|" ?) to pipe every (open) message in the thread. Which makes me think that other operations should work similarly. '+' and '-' should change tags on the current message (as they do currently) and then new "M-+" and "M--" could change tags on all (open) messages in the thread. That would highlight the current 'a' as out of place since it's currently archiving every message in the thread. So I'd then fix it to be 'a' for the current message and "M-a" for every (open) message in the thread. What do people think of that? -Carl --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iD8DBQFMD9RX6JDdNq8qSWgRAoyIAJ9bAd8Sz9BKLDsjwxdm9JDxsPveHwCcDfa8 uGGdUaE92wK2Ftbls6ozXxE= =VUf1 -----END PGP SIGNATURE----- --=-=-=--