DomainKey-Signature: a=rsa-sha1; c=nofws; d=SSpaeth.de; h=from:to:subject
	:in-reply-to:references:date:message-id:mime-version:
	content-type; q=dns; s=sspaeth.de; b=IofE7VngJ27TbOQyzQ6GBd5N3+E
	Gzilr45nCfyTPfjgiZdV9on0iUiAb5MWxFR2yQ/yr2V7w3brMEZMB51hvG5P1zT8
	UINVFOB4Q2l/VofkNo66i78zeLmneoGHGDGaKH5JRAIDYXCJ0mOj4M9SZ1ZZqE8b
	4Dh/D0Py7DQNiFAU=
From: Sebastian Spaeth <Sebastian@SSpaeth.de>
To: Justus Winter <4winter@informatik.uni-hamburg.de>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/9] python: add a .gitignore file and refine the toplevel
	one
In-Reply-To: <E1R9R9y-0003aa-Df@thinkbox.jade-hamburg.de>
References:
 <1316999137-28257-1-git-send-email-4winter@informatik.uni-hamburg.de>
	<871uuzlrkt.fsf@SSpaeth.de>	<E1R9R9y-0003aa-Df@thinkbox.jade-hamburg.de>
User-Agent: Notmuch/0.7-19-gee4579a (http://notmuchmail.org) Emacs/23.2.1
	(x86_64-pc-linux-gnu)
Date: Fri, 30 Sep 2011 11:14:31 +0200
Message-ID: <87hb3u4cjs.fsf@SSpaeth.de>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Fri, 30 Sep 2011 02:41:02 +0200, Justus Winter <4winter@informatik.uni-h=
amburg.de> wrote:
Non-text part: multipart/mixed
> Quoting Sebastian Spaeth (2011-09-29 09:45:38)
> >Also, not all "status" are an error, e.g. DuplicateMessageId denotes
> >success rather than failure, it just communicates a status.
>=20
> I just stumbled upon the following comment in notmuch.h:
>=20
> /* Status codes used for the return values of most functions.
>  *
>  * A zero value (NOTMUCH_STATUS_SUCCESS) indicates that the function
>  * completed without error. Any other value indicates an error as
>  * follows:
> [...]

That sounds like notmuch.h doesn't know what it wants :-). The "error"
can occur on add_message or remove_message and notmuch.h has to say:

on add_message:
 * If 'message' is not NULL, then, on successful return
 * (NOTMUCH_STATUS_SUCCESS or NOTMUCH_STATUS_DUPLICATE_MESSAGE_ID) '*messag=
e'
 * will be initialized to a message object that can be used for things
 * such as adding tags to the just-added message. The user should call
 * notmuch_message_destroy when done with the message. ... On any failure
 * '*message' will be set to NULL.

So DUPLICATE_MESSAGE_ID is definitely a successful return here, filling in =
the
Message object.

on remove_message:
 * NOTMUCH_STATUS_DUPLICATE_MESSAGE_ID: This filename was removed but
 *	the message persists in the database with at least one other
 *	filename.

Similarly, the operation succeeded, it's just that there are other
messages with that ID still around. One could argue whether this is an
error or not.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk6FiHgACgkQVYX1jMgnoGIBVgCgkPdZwgqKX6ailXsnpNjR5vog
peEAnAgiVUHZ6DxdkAWpoAMOKaYnnpx1
=jflB
-----END PGP SIGNATURE-----
--=-=-=--