Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 54B56431FB6 for ; Fri, 20 Jan 2012 01:41:32 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -1.098 X-Spam-Level: X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kiTzckU6tOGt for ; Fri, 20 Jan 2012 01:41:32 -0800 (PST) Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id DCCDB431FAE for ; Fri, 20 Jan 2012 01:41:31 -0800 (PST) Received: from smtp.qmul.ac.uk ([138.37.6.40]) by mail2.qmul.ac.uk with esmtp (Exim 4.71) (envelope-from ) id 1RoAyM-00075j-St; Fri, 20 Jan 2012 09:41:27 +0000 Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] helo=localhost) by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) (envelope-from ) id 1RoAyM-0005Zb-Lh; Fri, 20 Jan 2012 09:41:26 +0000 From: Mark Walters To: Austin Clements Subject: Re: [PATCH v4 1/1] Make buttons for attachments allow viewing as well as saving In-Reply-To: <20120120043023.GW16740@mit.edu> References: <1327008185-21194-2-git-send-email-markwalters1009@gmail.com> <20120120043023.GW16740@mit.edu> User-Agent: Notmuch/0.11+78~g7167de1 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) Date: Fri, 20 Jan 2012 09:42:18 +0000 Message-ID: <877h0mww05.fsf@qmul.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Sender-Host-Address: 94.192.233.223 X-QM-SPAM-Info: Sender has good ham record. :) X-QM-Body-MD5: 7dedd8d7d5ba9d019a59ef61fbcb5121 (of first 20000 bytes) X-SpamAssassin-Score: -1.8 X-SpamAssassin-SpamBar: - X-SpamAssassin-Report: The QM spam filters have analysed this message to determine if it is spam. We require at least 5.0 points to mark a message as spam. This message scored -1.8 points. Summary of the scoring: * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, * medium trust * [138.37.6.40 listed in list.dnswl.org] * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider * (markwalters1009[at]gmail.com) * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay * domain * 0.5 AWL AWL: From: address is in the auto white-list X-QM-Scan-Virus: ClamAV says the message is clean Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2012 09:41:32 -0000 On Thu, 19 Jan 2012 23:30:23 -0500, Austin Clements wrote: > One indentation nit and then this LGTM. > > > + (lexical-let ((message-id message-id) > > + (nth nth) > > + (filename filename) > > + (content-type content-type)) > > + (flet ((mm-save-part (&rest args) (notmuch-show-save-part > > This body of lexical-let should be indented like a normal let body. > You might have to load cl to get this indentation rule. Fixed. Patch to follow in reply. Thanks Mark