Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 54885431FBF for ; Thu, 10 Oct 2013 07:15:20 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UIgK0zk2s36v for ; Thu, 10 Oct 2013 07:15:12 -0700 (PDT) Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 6FC26431FAE for ; Thu, 10 Oct 2013 07:15:12 -0700 (PDT) Received: from remotemail by yantan.tethera.net with local (Exim 4.80) (envelope-from ) id 1VUH1B-0002NG-Gh; Thu, 10 Oct 2013 11:15:09 -0300 Received: (nullmailer pid 29797 invoked by uid 1000); Thu, 10 Oct 2013 14:15:05 -0000 From: David Bremner To: Tomi Ollila Subject: Re: [PATCH 1/3] cli: add insert --must-index option In-Reply-To: References: <1374365254-13227-1-git-send-email-novalazy@gmail.com> <87ip048gbj.fsf@qmul.ac.uk> <20130727151510.GA13750@hili.localdomain> <87hadtxfrr.fsf@qmul.ac.uk> <20130912001349.GA18821@hili.localdomain> <87zjqhv264.fsf@zancas.localnet> User-Agent: Notmuch/0.16 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Thu, 10 Oct 2013 11:15:05 -0300 Message-ID: <87bo2xtdp2.fsf@unb.ca> MIME-Version: 1.0 Content-Type: text/plain Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Oct 2013 14:15:20 -0000 Tomi Ollila writes: >> I'm not opposed to doing an SONAME bump for 0.17. Are there other ABI >> breaking changes that we have been holding back on? Can these maybe go >> through at the same time? > > Maybe something along these lines... > > (Quick draft for the API part; to start discussion before working too much > for something that is going to be dropped...) > > notmuch_status_t > -notmuch_database_create (const char *path, notmuch_database_t **database); > +notmuch_database_create (const char *path, > + notmuch_loghook_t *loghook, > + notmuch_database_t **database); Another idea floated (by Austin?) was to pass in an options struct, to allow future options to be added without changing the function signature. I guess with some care this could be done in an upwardly compatible way. d