Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id B1AE6429E38 for ; Sat, 14 Jan 2012 01:04:15 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8TiMetlT2T3G for ; Sat, 14 Jan 2012 01:04:13 -0800 (PST) Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 993A9431FB6 for ; Sat, 14 Jan 2012 01:04:13 -0800 (PST) Received: by wgbds11 with SMTP id ds11so3530845wgb.2 for ; Sat, 14 Jan 2012 01:04:12 -0800 (PST) Received: by 10.180.14.161 with SMTP id q1mr2127871wic.1.1326531852317; Sat, 14 Jan 2012 01:04:12 -0800 (PST) Received: from localhost ([109.131.75.86]) by mx.google.com with ESMTPS id 28sm14164453wby.3.2012.01.14.01.04.11 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 14 Jan 2012 01:04:11 -0800 (PST) From: Pieter Praet To: David Bremner Subject: Re: [PATCH v2] emacs: logically group def{custom,face}s In-Reply-To: <87fwfknuqx.fsf@zancas.localnet> References: <87bos6tcgp.fsf@zancas.localnet> <1326388336-15940-1-git-send-email-pieter@praet.org> <87fwfknuqx.fsf@zancas.localnet> User-Agent: Notmuch/0.10.2+115~gadd29f6 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) Date: Sat, 14 Jan 2012 10:02:30 +0100 Message-ID: <87ty3ypsgp.fsf@praet.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Notmuch Mail X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jan 2012 09:04:15 -0000 On Thu, 12 Jan 2012 23:31:34 -0400, David Bremner wrote: > On Thu, 12 Jan 2012 18:12:16 +0100, Pieter Praet wrote: > > To allow for expansion whilst keeping everything tidy and organized, > > move all defcustom/defface variables to the following subgroups, > > defined in notmuch-lib.el: > > > > - Hello > > - Search > > - Show > > - Send > > - Crypto > > - Hooks > > - Appearance > > - External Commands > > I didn't investigate too closely, but I noticed when I customize-group > emacs, each subgroup has some explanatory text beside it. Did you omit > that on purpose? > That is correct. Coming up with decent docstrings is hard :) Also, the group names are fairly descriptive in and of themselves IMO. Anyways, I've given it a shot, but (I hope!) people will come up with much better descriptions, so this probably isn't the end of it... Patch follows. > d Peace -- Pieter