From: Mark Walters <markwalters1009@gmail.com>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 3/3] test: Update tests for 'authors_matched'
	and	authors_non_matched'.
In-Reply-To: <1414172643-28270-4-git-send-email-dme@dme.org>
References: <1414172643-28270-1-git-send-email-dme@dme.org>
	<1414172643-28270-4-git-send-email-dme@dme.org>
User-Agent: Notmuch/0.18.1+86~gef5e66a (http://notmuchmail.org) Emacs/24.4.1
	(x86_64-pc-linux-gnu)
Date: Sun, 18 Jan 2015 18:12:13 +0000
Message-ID: <87lhl0j6v6.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list


Hi

Only one small comment here: it would be nice to have a test that has a
non-empty authors_non_matched field.

Best wishes

Mark

On Fri, 24 Oct 2014, David Edmondson <dme@dme.org> wrote:
> ---
>  test/T160-json.sh            | 9 +++++++++
>  test/T170-sexp.sh            | 4 ++--
>  test/T470-missing-headers.sh | 8 ++++++++
>  3 files changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/test/T160-json.sh b/test/T160-json.sh
> index c1cf649..0a8df18 100755
> --- a/test/T160-json.sh
> +++ b/test/T160-json.sh
> @@ -25,6 +25,10 @@ test_expect_equal_json "$output" "[{\"thread\": \"XXX\=
",
>   \"matched\": 1,
>   \"total\": 1,
>   \"authors\": \"Notmuch Test Suite\",
> + \"authors_matched\": [
> +     \"Notmuch Test Suite\"
> + ],
> + \"authors_non_matched\": [],
>   \"subject\": \"json-search-subject\",
>   \"query\": [\"id:$gen_msg_id\", null],
>   \"tags\": [\"inbox\",
> @@ -59,6 +63,11 @@ test_expect_equal_json "$output" "[{\"thread\": \"XXX\=
",
>   \"matched\": 1,
>   \"total\": 1,
>   \"authors\": \"Notmuch Test Suite\",
> + \"authors\": \"Notmuch Test Suite\",
> + \"authors_matched\": [
> +     \"Notmuch Test Suite\"
> + ],
> + \"authors_non_matched\": [],
>   \"subject\": \"json-search-utf8-body-s=C3=BCbj=C3=A9ct\",
>   \"query\": [\"id:$gen_msg_id\", null],
>   \"tags\": [\"inbox\",
> diff --git a/test/T170-sexp.sh b/test/T170-sexp.sh
> index 667e319..f2a08bf 100755
> --- a/test/T170-sexp.sh
> +++ b/test/T170-sexp.sh
> @@ -19,7 +19,7 @@ test_expect_equal "$output" "((((:id \"${gen_msg_id}\" =
:match t :excluded nil :f
>  test_begin_subtest "Search message: sexp"
>  add_message "[subject]=3D\"sexp-search-subject\"" "[date]=3D\"Sat, 01 Ja=
n 2000 12:00:00 -0000\"" "[body]=3D\"sexp-search-message\""
>  output=3D$(notmuch search --format=3Dsexp "sexp-search-message" | notmuc=
h_search_sanitize)
> -test_expect_equal "$output" "((:thread \"0000000000000002\" :timestamp 9=
46728000 :date_relative \"2000-01-01\" :matched 1 :total 1 :authors \"Notmu=
ch Test Suite\" :subject \"sexp-search-subject\" :query (\"id:$gen_msg_id\"=
 nil) :tags (\"inbox\" \"unread\")))"
> +test_expect_equal "$output" "((:thread \"0000000000000002\" :timestamp 9=
46728000 :date_relative \"2000-01-01\" :matched 1 :total 1 :authors \"Notmu=
ch Test Suite\" :authors_matched (\"Notmuch Test Suite\") :authors_non_matc=
hed () :subject \"sexp-search-subject\" :query (\"id:$gen_msg_id\" nil) :ta=
gs (\"inbox\" \"unread\")))"
>=20=20
>  test_begin_subtest "Show message: sexp, utf-8"
>  add_message "[subject]=3D\"sexp-show-utf8-body-s=C3=BCbj=C3=A9ct\"" "[da=
te]=3D\"Sat, 01 Jan 2000 12:00:00 -0000\"" "[body]=3D\"js=C3=B6n-show-m=C3=
=A9ssage\""
> @@ -44,7 +44,7 @@ test_expect_equal "$output" "((((:id \"$id\" :match t :=
excluded nil :filename \"
>  test_begin_subtest "Search message: sexp, utf-8"
>  add_message "[subject]=3D\"sexp-search-utf8-body-s=C3=BCbj=C3=A9ct\"" "[=
date]=3D\"Sat, 01 Jan 2000 12:00:00 -0000\"" "[body]=3D\"js=C3=B6n-search-m=
=C3=A9ssage\""
>  output=3D$(notmuch search --format=3Dsexp "js=C3=B6n-search-m=C3=A9ssage=
" | notmuch_search_sanitize)
> -test_expect_equal "$output" "((:thread \"0000000000000005\" :timestamp 9=
46728000 :date_relative \"2000-01-01\" :matched 1 :total 1 :authors \"Notmu=
ch Test Suite\" :subject \"sexp-search-utf8-body-s=C3=BCbj=C3=A9ct\" :query=
 (\"id:$gen_msg_id\" nil) :tags (\"inbox\" \"unread\")))"
> +test_expect_equal "$output" "((:thread \"0000000000000005\" :timestamp 9=
46728000 :date_relative \"2000-01-01\" :matched 1 :total 1 :authors \"Notmu=
ch Test Suite\" :authors_matched (\"Notmuch Test Suite\") :authors_non_matc=
hed () :subject \"sexp-search-utf8-body-s=C3=BCbj=C3=A9ct\" :query (\"id:$g=
en_msg_id\" nil) :tags (\"inbox\" \"unread\")))"
>=20=20
>=20=20
>  test_done
> diff --git a/test/T470-missing-headers.sh b/test/T470-missing-headers.sh
> index cb38301..250a370 100755
> --- a/test/T470-missing-headers.sh
> +++ b/test/T470-missing-headers.sh
> @@ -34,6 +34,10 @@ test_expect_equal_json "$output" '
>  [
>      {
>          "authors": "",
> +        "authors_matched": [
> +            ""
> +        ],
> +        "authors_non_matched": [],
>          "date_relative": "2001-01-05",
>          "matched": 1,
>          "subject": "",
> @@ -48,6 +52,10 @@ test_expect_equal_json "$output" '
>      },
>      {
>          "authors": "Notmuch Test Suite",
> +        "authors_matched": [
> +            "Notmuch Test Suite"
> +        ],
> +        "authors_non_matched": [],
>          "date_relative": "1970-01-01",
>          "matched": 1,
>          "subject": "",
> --=20
> 2.1.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch