Date: Sat, 11 Oct 2014 00:10:00 -0700
From: "W. Trevor King" <wking@tremily.us>
To: David Bremner <david@tethera.net>
Subject: Re: [PATCH v2] nmbug: Add an 'init' command
Message-ID: <20141011071000.GB10926@odin.tremily.us>
References:
 <eaa9cf1cb3c00c591dc675c0f314ca31909ff74c.1412965476.git.wking@tremily.us>
	<8761frgqbs.fsf@maritornes.cs.unb.ca>
	<20141011051153.GA10926@odin.tremily.us>
	<87siivf5s3.fsf@maritornes.cs.unb.ca>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="Y7xTucakfITjPcLV"
Content-Disposition: inline
In-Reply-To: <87siivf5s3.fsf@maritornes.cs.unb.ca>
OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8;
	url=http://tremily.us/pubkey.txt
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: notmuch@notmuchmail.org
Precedence: list


--Y7xTucakfITjPcLV
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Oct 11, 2014 at 09:02:20AM +0200, David Bremner wrote:
> W. Trevor King writes:
> > On Sat, Oct 11, 2014 at 06:53:11AM +0200, David Bremner wrote:
> >> W. Trevor King writes:
> >> > but I expect that closing stdin is more portable than the
> >> > /dev/null path.
> >>=20
> >> /dev/null is part of POSIX
> >
> > Maybe folks want to use nmbug on Windows or some other crazy
> > non-POSIX OS?  I don't know how Windows-compatible the rest of
> > notmuch is (it looks like Xapian can be built with MSYS+mingw or
> > MSVC [1,2]), and I don't think supporting non-POSIX OSes is worth
> > a lot of effort, but using stdin instead here is easy ;).
>=20
> I have no objection to the code, but I think the comment about
> portability just causes confusion. As witnessed by this discussion.

I wanted to explain why I wasn't using /dev/null, especially since
that's what the Perl version used and that phrasing is preserved in
the current comment:

  # magic hash for Git (git hash-object -t blob /dev/null)                 =
      =20
  _EMPTYBLOB =3D 'e69de29bb2d1d6434b8b29ae775ad8c2e48c5391'

So how should I more clearly explain why I prefer stdin to /dev/null?
Maybe =E2=80=9C=E2=80=A6 is more portable than the /dev/null path (which do=
esn't exist
on Windows, for example).=E2=80=9D?

Cheers,
Trevor

--=20
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

--Y7xTucakfITjPcLV
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJUONfAAAoJEG8/JgBt8ol826gP/jQeehj9yd7WVMOF4qr5q/aq
nq8oUm+vFK6zQQfRLywGWVMO2ITUoNvEm318I7cm0qyP5Z3yrs/CsdKoLuHeyKju
CEYIj61YMgZ4p3Vhvt9sS4matk65k51ky7WxLEC4DjCQQARVmdndG4PFc5z6V6vY
IpBaNSeahfUBUAn1acPvBAGeUgTAYTrKR/+qi5pnHBioq8fz55F7Cj0akYK8MrdL
+ijdNewmHg0Ju4Pk1+z2zPzJC9R+YFwTp3An5gekOS1IjZgYDTxJz7fsUISSpq9y
m8nRRxhEt2QoxsjRtxZiJm+hhbndIkPxIHE3tJ5tPZVXHU+eg76EX4nNMgCatr6S
0quz2W80pcoIym8kmKqiRa+4wmesXGcz0bHdeNqPq4/z90oi+J89SZw2xf605F3D
uEEVp4zfJa77iRRnw22WXZewDjQpjJyTU1nK4SpmHSG+ULJvLpS/f2WCogrYMzyf
TKuWIfNtcxKt0ydF0it3OFBmRdbo5V+Re5HmDywu8Ynxz2WI7KQbvnCWevCaaP4+
RhKYRPc7L+1SrJHlh+i2gkvhE5ALM7bIPuOpeD86ynZobJ351zoCcWR4t5Jv2NgS
/XHZiu1Xv4BgdDR+iqpvQ0+QuyHOWN5FG9TWaWeQqmxA6X0NXe14Ob2tbHjJbA2f
5WyIiFnS148QsSSNN6CD
=MCVI
-----END PGP SIGNATURE-----

--Y7xTucakfITjPcLV--