From: Jameson Rollins <jrollins@finestructure.net>
To: Carl Worth <cworth@cworth.org>, racin@free.fr, Sebastian Spaeth
	<Sebastian@SSpaeth.de>
In-Reply-To: <87sk8qwjlt.fsf@yoom.home.cworth.org>
References:
 <1161359196.2247691263984967906.JavaMail.root@zimbra1-e1.priv.proxad.net>
	<87sk8qwjlt.fsf@yoom.home.cworth.org>
Date: Wed, 24 Feb 2010 14:01:18 -0500
Message-ID: <87tyt61mrl.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Cc: notmuch <notmuch@notmuchmail.org>
Subject: Re: [notmuch] [PATCH] add notmuch-show-delete keybinding 'd'
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Wed, 24 Feb 2010 10:53:50 -0800, Carl Worth <cworth@cworth.org> wrote:
> But this patch does have two good ideas not in the other patch, (both of
> which I mentioned in the review):
>=20
> 1. It adds a keybinding to the notmuch-show mode
>=20
> 2. It removes the "inbox" and "unread" tags while adding the tag to
>    indicate deletion.

Hey, Carl.  Why is this last point important?  I've been using my own
patchs for handling deleted messages, and all deleting a message or
thread does is add the "delete" tag.  Why should it modify any other
tags?  A message/thread should be allowed to be both deleted and in the
inbox.

As for "unread", I think that should be handled by actually reading the
message, not by manually applying a state to it.

FWIW, below are the functions I've added to my notmuch .el to handle
message/thread deleting.

jamie.

(defun notmuch-search-delete-thread ()
  "Delete thread (add \"delete\" tag).

This function advances the next thread when finished."
  (interactive)
  (notmuch-search-add-tag "delete")
  (forward-line))

(define-key notmuch-search-mode-map "d" 'notmuch-search-delete-thread)

(defun notmuch-show-delete-message ()
  "Delete message (add \"delete\" tag).

Add the \"delete\" tag to message. Then kill this buffer and
show the next thread from the search from which this thread was
originally shown."
  (interactive)
  (notmuch-show-add-tag "delete")
  (let ((parent-buffer notmuch-show-parent-buffer))
    (kill-this-buffer)
    (if parent-buffer
	(progn
	  (switch-to-buffer parent-buffer)
	  (forward-line)))))

(define-key notmuch-show-mode-map "d" 'notmuch-show-delete-message)

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBCAAGBQJLhXd/AAoJEO00zqvie6q8UKYP/RpDAHG9cGVCcNKyHp3C5iFm
H8Th94jndZK2CEUDpPM0oqZ9z5xENTdb46OEjsfX35CuFAXAsJ2F0hqsKOtLp7F+
HKrCkrJth4+x8qn9jFSPh9U8FJjuG8NgtlzkiR0VuLW6KWgY/JU+ye9tIql6rFNM
5PqRBxhVeGB9k+mq6vUXJxWrrbnIalAG3/QCSKLOZJKC8I0fKPsOwq55vgObkRn5
kwjw1uFsA3RG8vg2qRl+qmMyGDl3IxoYBRZwx6hrL+o+mMjmHqlh4xCKCQHCWgqN
CbK9pTRG0aMbSkJoyQH1FtTnQMC0ZWCnFV00ptdsDAHnSL++rP9R9pj/blnml1fT
jLKZC19A8+9HqBOXFpKUq4IRyG7/QZSVE0CLl5iQlplxsswuQAnLbPEpveq8fJQ7
q+ei22t4G/AXrVg1ZaNfTgN1OJik1deDsEUSzs67XVe3mYfRrNcWH5WJ8lRqtHmb
mRt8wEyC4t/p6Xd2IplfLZIau//ca6oM0r7UahXqBWgRpqEVLmigufMTeSJxSsFq
jS3XTd2lUx8WYgiJujKJmmyft1XQZJFxlmRUEi/SLjQOL5L/t570ctOhvmSiD3E/
GW3Hjql/Y4Hexaezcmv0uYxf8Oi9H7dV/IdTf62o2mUfiahUR8PcW6+PJRAd9djm
vUHmcEMZvdeKFwssyCyA
=yD4W
-----END PGP SIGNATURE-----
--=-=-=--