Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 26DE8431FC4 for ; Sat, 5 May 2012 16:25:27 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id asUpWsctR0zO for ; Sat, 5 May 2012 16:25:26 -0700 (PDT) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id 9218E431FAE for ; Sat, 5 May 2012 16:25:26 -0700 (PDT) Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) by fire-doxen-postvirus (Postfix) with ESMTP id 25BB92E50C73; Sat, 5 May 2012 16:25:24 -0700 (PDT) X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new Received: from finestructure.net (66-189-196-221.dhcp.yakm.wa.charter.com [66.189.196.221]) (Authenticated sender: jrollins) by fire-doxen-submit (Postfix) with ESMTP id 28F432E50DA5; Sat, 5 May 2012 16:25:19 -0700 (PDT) Received: by finestructure.net (Postfix, from userid 1000) id BC257496; Sat, 5 May 2012 16:21:01 -0700 (PDT) From: Jameson Graef Rollins To: Thomas Jost , notmuch@notmuchmail.org Subject: Re: [PATCH v6] emacs: Let the user choose where to compose new mails In-Reply-To: <1336127876-6765-1-git-send-email-schnouki@schnouki.net> References: <87k40yfj2z.fsf@zancas.localnet> <1336127876-6765-1-git-send-email-schnouki@schnouki.net> User-Agent: Notmuch/0.12+139~g0f7ffba (http://notmuchmail.org) Emacs/23.4.1 (x86_64-pc-linux-gnu) Date: Sat, 05 May 2012 16:20:59 -0700 Message-ID: <87txzunrj8.fsf@servo.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2012 23:25:27 -0000 --=-=-= On Fri, May 04 2012, Thomas Jost wrote: > Here it is again, with a warning in the customize message that only > appears in Emacs 23. The indentation is a little bit of a mess but > that's needed for the docstring to look good :) Great! That's a nice trick, Thomas. Thanks. This should definitely address David's concerns. > (If you want I can remove the test and also display the Emacs 23 > warning in Emacs 24.) I think the included solution is perfect. > Does it look good to you? I'm not comfortable with writing docs in > English, so feel free to rephrase it if needed. Yes, it is good. It reads well and includes all the relevant information. > I also moved notmuch-mua-compose-in to the 'notmuch-send group, just > as other notmuch-mua-* variables. Perfect. I have reviewed and tested this updated version of the patch and everything looks and works great. Thank you so much for topping this off, Thomas. jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBCAAGBQJPpbXbAAoJEO00zqvie6q8iKQQAJPmwg7ybEUIMacQRsM+sHEr pnUpZD9p7U0krb4pZtN5qKMFvhKVS2HJUv+XWPuqx4KBranFp3M6QrIPh3IqCNEx uQpogxEyO5ZasTtUDhWJ+3S9U0lqf4RGVsnAeih4LjYizwTcNn00o7k5cGwXdozD 3FsixQjyBQU+UkzzQgDC3VwXeTa79dqRcrC+bfuzuJoRBAm0tW/HUn44MjPvZRp0 7NMGBFMUT6tKBjPWfoWQ4kuMXHUdwY6uipOCOnfVNBpTMkrI879pkdkTfAXRB3rO qTob96q+yuDz9usxAFEG9DI6dgfRHOa2wmusGLaFxSodAvOUxjPL+OWREy/X7nOd cYSYPLaIdmuiagh5NaupDhJRPwRRs2c+KdFkgUV9B6SH6tFlPCOSKAc3X02G9Zbq Mx4MpBJ1P0ux1jDkD6gUuIBLSWBdHkGv7pW5cW2rMWb2IGu1D3uL+vNJKqcbdKIt iTbTqxP4xg26dDdyr6dMI5jNnmSN8EXDggDnsS9ziIMtKLPMKoAGGvJ7xxmDTwA2 TXK9YxScQ7Qynrt/e0wDg6aitPcKhPWvNQXrFnnu5rA5Kcxsr23WPzcTCm5rDWld NKrNBmP4yUFefNI/H2rdg7nAEEAJIakBwTBa0XcWsmxmWVMliNuC2yk68KBWJ/YO VZCRGWjpXSIFfqUSAoAl =IV7X -----END PGP SIGNATURE----- --=-=-=--