From: "Sebastian Spaeth" <Sebastian@SSpaeth.de>
To: Jameson Rollins <jrollins@finestructure.net>, Carl Worth
	<cworth@cworth.org>, Notmuch Mail list <notmuch@notmuchmail.org>
In-Reply-To: <87r5oa1lvo.fsf@servo.finestructure.net>
References: <87ska1vh7r.fsf@servo.finestructure.net>
	<87ljes0yy0.fsf@SSpaeth.de> <87vddmwkuw.fsf@yoom.home.cworth.org>
	<87r5oa1lvo.fsf@servo.finestructure.net>
Date: Thu, 25 Feb 2010 11:23:40 +0100
Message-ID: <87hbp5bolv.fsf@SSpaeth.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [notmuch] [PATCH] Simplify "unread" tag handling in emacs UI.
Precedence: list

On Wed, 24 Feb 2010 14:20:27 -0500, Jameson Rollins <jrollins@finestructure=
.net> wrote:
> On Wed, 24 Feb 2010 10:26:47 -0800, Carl Worth <cworth@cworth.org> wrote:

> > > It then checks the unread status in order to decide whether to proceed
> > > to the next again. So with your patch notmuch-show-next-unread-message
> > > will skip through all messages in a thread thinking they are all read
> > > (and actually marking all as read).
> >=20
> > ...that seems like a fatal bug in this script. Thanks for noting that
> > Sebastian.
>=20
> I certainly don't see it as fatal, but it is something we should
> resolve.  I think the simplification that the patch provides is worth
> it.

Well, it is fatal in the sense that it makes that function useless. But
it's not as bad as it is currently unused. You will only notice it if you
make the "skip to next unread" (interactive) and bind it to a key (which
is what I have done). I still think it's worth taking this patch and fixing=
 it then.

The solutions I can see are:=20
- split into a "notmuch-show-next-message"
  and a notmuch-show-show-next-message (what a naming!) function.=20
  One would merely skip to the next and one actually show and mark unread.
- Introduce a second argument option whether we should mark as unread or no=
t.
- rework "notmuch-show-next-unread-message" to not make use of
  "notmuch-show-next-message" but e.g. to just use
  "notmuch-show-find-next-message" or so.

Does this make any sense?

> I'm seeing the notmuch-show-next-unread-message as a non-interactive
> function that's not currently called by any other functions, and is
> therefore not being used.  Sebastian, are you using that in a private
> function, or am I misreading the code?

Touch=C3=A9. As explained above. I made it interactive and bound it to 'n'.

Sebastian