To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/4] test: Add `test_emacs_expect_t'.
In-Reply-To: <87pqei327k.fsf@gmail.com>
References: <1326804748-8989-1-git-send-email-dme@dme.org>
	<1326804748-8989-2-git-send-email-dme@dme.org>
	<87pqei327k.fsf@gmail.com>
User-Agent: Notmuch/0.11+64~g42e8f66 (http://notmuchmail.org) Emacs/24.0.92.1
	(x86_64-pc-linux-gnu)
From: David Edmondson <dme@dme.org>
Date: Tue, 17 Jan 2012 13:24:55 +0000
Message-ID: <cun1uqyqx5k.fsf@hotblack-desiato.hh.sledj.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

(And one for the list...)

On Tue, 17 Jan 2012 17:09:35 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmai=
l.com> wrote:
> -1
>=20
> This is not what I suggested.  I do not like the approach when a single
> function is used to both declare a subtest and test for result (as
> opposed to test_begin_subtest).  The fact that it is possible to write
> tests in two different ways makes it hard to maintain and improve the
> test framework (one example would be known broken test support).  I
> consider the proper way to write tests to be using the
> test_begin_subtest function.  Other functions are not currently
> deprecated, but I am against adding new code that make the situation
> worse.

Sigh. Okay.

> Also, please consider documenting new functions in README.

Missed that, sorry.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk8VdqcACgkQaezQq/BJZRaqSQCferjCVknfMKUg6dhMwVvnG8Ux
LmcAoIgu2l7soNTfCmYRR5cWyzTbLRuZ
=AIkY
-----END PGP SIGNATURE-----
--=-=-=--