recentchanges: delete CGI hook in favour of the global one
authorSimon McVittie <smcv@ http://smcv.pseudorandom.co.uk/>
Sat, 31 Jan 2009 14:49:25 +0000 (14:49 +0000)
committerSimon McVittie <smcv@ http://smcv.pseudorandom.co.uk/>
Sat, 31 Jan 2009 14:49:25 +0000 (14:49 +0000)
IkiWiki/Plugin/recentchanges.pm

index ef108b3f00d4f031ef3ca3b0f1bab228f0dce279..56e80e7b815954e8a42c32bc284a03a62e94e327 100644 (file)
@@ -13,7 +13,6 @@ sub import {
        hook(type => "refresh", id => "recentchanges", call => \&refresh);
        hook(type => "pagetemplate", id => "recentchanges", call => \&pagetemplate);
        hook(type => "htmlize", id => "_change", call => \&htmlize);
-       hook(type => "cgi", id => "recentchanges", call => \&cgi);
 }
 
 sub getsetup () {
@@ -79,48 +78,6 @@ sub htmlize (@) {
        return $params{content};
 }
 
-sub cgi ($) {
-       my $cgi=shift;
-       if (defined $cgi->param('do') && $cgi->param('do') eq "recentchanges_link") {
-               # This is a link from a change page to some
-               # other page. Since the change pages are only generated
-               # once, statically, links on them won't be updated if the
-               # page they link to is deleted, or newly created, or
-               # changes for whatever reason. So this CGI handles that
-               # dynamic linking stuff.
-               my $page=decode_utf8($cgi->param("page"));
-               if (!defined $page) {
-                       error("missing page parameter");
-               }
-
-               IkiWiki::loadindex();
-
-               # If the page is internal (like a comment), see if it has a
-               # permalink. Comments do.
-               if (IkiWiki::isinternal($page) &&
-                   defined $pagestate{$page}{meta}{permalink}) {
-                       IkiWiki::redirect($cgi,
-                                         $pagestate{$page}{meta}{permalink});
-                       exit;
-               }
-
-               my $link=bestlink("", $page);
-               if (! length $link) {
-                       print "Content-type: text/html\n\n";
-                       print IkiWiki::misctemplate(gettext(gettext("missing page")),
-                               "<p>".
-                               sprintf(gettext("The page %s does not exist."),
-                                       htmllink("", "", $page)).
-                               "</p>");
-               }
-               else {
-                       IkiWiki::redirect($cgi, urlto($link, undef, 1));
-               }
-
-               exit;
-       }
-}
-
 sub store ($$$) {
        my $change=shift;
 
@@ -138,7 +95,7 @@ sub store ($$$) {
                        if (length $config{cgiurl}) {
                                $_->{link} = "<a href=\"".
                                        IkiWiki::cgiurl(
-                                               do => "recentchanges_link",
+                                               do => "goto",
                                                page => $_->{page}
                                        ).
                                        "\" rel=\"nofollow\">".