From ffc770a1dddfc1e2083b29c9a8143a4f5846c0f9 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Sat, 17 Jan 2015 13:57:31 +0100 Subject: [PATCH] Re: [v2 3/3] thread-naming test: Test empty subject names. --- 53/33d4981ba4e97d199ca0fe35c787a6a9b68b1e | 73 +++++++++++++++++++++++ 1 file changed, 73 insertions(+) create mode 100644 53/33d4981ba4e97d199ca0fe35c787a6a9b68b1e diff --git a/53/33d4981ba4e97d199ca0fe35c787a6a9b68b1e b/53/33d4981ba4e97d199ca0fe35c787a6a9b68b1e new file mode 100644 index 000000000..ad60b00e8 --- /dev/null +++ b/53/33d4981ba4e97d199ca0fe35c787a6a9b68b1e @@ -0,0 +1,73 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 240A7431FC2 + for ; Sat, 17 Jan 2015 04:57:40 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 2.438 +X-Spam-Level: ** +X-Spam-Status: No, score=2.438 tagged_above=-999 required=5 + tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id hxEBwXDJ-p23 for ; + Sat, 17 Jan 2015 04:57:37 -0800 (PST) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id EC0C0431FAF + for ; Sat, 17 Jan 2015 04:57:36 -0800 (PST) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1YCSwa-000779-8Y; Sat, 17 Jan 2015 08:57:36 -0400 +Received: (nullmailer pid 1443 invoked by uid 1000); Sat, 17 Jan 2015 + 12:57:31 -0000 +From: David Bremner +To: Jesse Rosenthal , notmuch@notmuchmail.org +Subject: Re: [v2 3/3] thread-naming test: Test empty subject names. +In-Reply-To: <87h9vzj87r.fsf@maritornes.cs.unb.ca> +References: <1414615905-22554-1-git-send-email-jrosenthal@jhu.edu> + <1414615905-22554-4-git-send-email-jrosenthal@jhu.edu> + <87h9vzj87r.fsf@maritornes.cs.unb.ca> +User-Agent: Notmuch/0.19+21~g71fb37d (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +Date: Sat, 17 Jan 2015 13:57:31 +0100 +Message-ID: <87d26dbm4k.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 17 Jan 2015 12:57:40 -0000 + +David Bremner writes: + +> Jesse Rosenthal writes: +> +>> +>> +test_begin_subtest "Use empty subjects if necessary." +>> +add_message '[subject]="@FORCE_EMPTY"' \ +>> + '[date]="Sat, 13 Jan 2001 15:43:45 -0000"' \ +>> + '[from]="Empty Sender \ +> It seems to me we should avoid notmuchmail.org addresses in the test +> suite. Maybe this is too picky, but if you are going to fixup the white +> space errors, how about also changing to example.{org,net,com} +> addresses. + +I realized we use such addresses everywhere, so this is at least +consistent with the existing code. I pushed the series with the +whitespace fixups. + +d -- 2.26.2