From fe16c6ef00353c0874cb61069c4f6e3e12077a1e Mon Sep 17 00:00:00 2001 From: David Bremner Date: Mon, 3 Feb 2014 19:18:31 +2000 Subject: [PATCH] Re: [PATCH] configure: only install bash completion if supported --- 92/19d184bbd28c14d617b671a3cc82dba725a495 | 74 +++++++++++++++++++++++ 1 file changed, 74 insertions(+) create mode 100644 92/19d184bbd28c14d617b671a3cc82dba725a495 diff --git a/92/19d184bbd28c14d617b671a3cc82dba725a495 b/92/19d184bbd28c14d617b671a3cc82dba725a495 new file mode 100644 index 000000000..fa7a8faa1 --- /dev/null +++ b/92/19d184bbd28c14d617b671a3cc82dba725a495 @@ -0,0 +1,74 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 183EF431FBD + for ; Sun, 2 Feb 2014 15:18:45 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 9bVSR1j2XPTc for ; + Sun, 2 Feb 2014 15:18:41 -0800 (PST) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 1A1C8431FBC + for ; Sun, 2 Feb 2014 15:18:41 -0800 (PST) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1WA6JA-0004kO-9L; Sun, 02 Feb 2014 19:18:36 -0400 +Received: (nullmailer pid 18291 invoked by uid 1000); Sun, 02 Feb 2014 + 23:18:31 -0000 +From: David Bremner +To: Jani Nikula , Mark Walters , + notmuch@notmuchmail.org +Subject: Re: [PATCH] configure: only install bash completion if supported +In-Reply-To: <87vbwxw6u2.fsf@nikula.org> +References: <1391359677-12497-1-git-send-email-jani@nikula.org> + <877g9dqup5.fsf@qmul.ac.uk> <878utt1b9s.fsf@maritornes.cs.unb.ca> + <87vbwxw6u2.fsf@nikula.org> +User-Agent: Notmuch/0.17+56~gb9c3d8e (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 02 Feb 2014 19:18:31 -0400 +Message-ID: <87lhxt14u0.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 02 Feb 2014 23:18:45 -0000 + +Jani Nikula writes: + +> On Sun, 02 Feb 2014, David Bremner wrote: +>> Mark Walters writes: +>> +>>> This LGTM (untested) +>> +>> I did test it, at least completely removing bash completion works as +>> expected. +>> +>> Unfortunately --with-bash-completion does not override this test because +>> the order things are processed. Do you think this is a bug? I wondered +>> if users that "know what they are doing" (TM) might want to force +>> installation even though the pkg-config test fails. +> +> I thought it was a feature, not a bug, but I'm fine either way. + +I can live with the current patch. As you pointed out on IRC, this is +the usual way missing dependencies work. And I think we should avoid +extra complications in the configure script when we can. -- 2.26.2