From fd7141d96bf9326c3870541a431d2055e72566d1 Mon Sep 17 00:00:00 2001 From: Tom Yu Date: Thu, 7 Nov 2002 22:43:46 +0000 Subject: [PATCH] rpc unit tests can fail due to race condition The rpc unit tests can fail in fullrun.exp due to a failure to drain output from the server in expire.exp. This commit works around the problem by calling flush_server, but a real synchronization method should probably be implemented, perhaps by having the server log when a client disconnects. * rpc_test.0/expire.exp (overlap): Add another call to flush_server to make a race condition a little less likely. There really should be better synchronization, as this test suite is just full of race conditions waiting to happen. ticket: new status: open git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14979 dc483132-0cff-0310-8789-dd5450dbe970 --- src/lib/rpc/unit-test/ChangeLog | 7 +++++++ src/lib/rpc/unit-test/rpc_test.0/expire.exp | 2 ++ 2 files changed, 9 insertions(+) diff --git a/src/lib/rpc/unit-test/ChangeLog b/src/lib/rpc/unit-test/ChangeLog index 273a2c26d..06504cfbb 100644 --- a/src/lib/rpc/unit-test/ChangeLog +++ b/src/lib/rpc/unit-test/ChangeLog @@ -1,3 +1,10 @@ +2002-11-07 Tom Yu + + * rpc_test.0/expire.exp (overlap): Add another call to + flush_server to make a race condition a little less likely. There + really should be better synchronization, as this test suite is + just full of race conditions waiting to happen. + 2002-09-15 Ken Raeburn * lib/helpers.exp (setup_database): Use "!=" instead of "ne" for diff --git a/src/lib/rpc/unit-test/rpc_test.0/expire.exp b/src/lib/rpc/unit-test/rpc_test.0/expire.exp index 6f7aa935a..5c33ffde5 100644 --- a/src/lib/rpc/unit-test/rpc_test.0/expire.exp +++ b/src/lib/rpc/unit-test/rpc_test.0/expire.exp @@ -38,6 +38,8 @@ proc overlap {} { eof_client expire 1 $client1_id 0 eof_client expire 2 $client2_id 0 eof_client expire 3 $client3_id 0 + + flush_server } overlap -- 2.26.2