From fcef7358bb7d127bdb9b3799152075d797124779 Mon Sep 17 00:00:00 2001 From: Kim Minh Kaplan Date: Thu, 3 Apr 2014 06:17:44 +0000 Subject: [PATCH] Re: [Patch v5 3/6] util: add gz_readline --- 38/5dad1343b3df4327c9fde847510842690882bb | 85 +++++++++++++++++++++++ 1 file changed, 85 insertions(+) create mode 100644 38/5dad1343b3df4327c9fde847510842690882bb diff --git a/38/5dad1343b3df4327c9fde847510842690882bb b/38/5dad1343b3df4327c9fde847510842690882bb new file mode 100644 index 000000000..31166f804 --- /dev/null +++ b/38/5dad1343b3df4327c9fde847510842690882bb @@ -0,0 +1,85 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 3EFA5431FBF + for ; Wed, 2 Apr 2014 23:18:22 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id XHeyKtqvJRuQ for ; + Wed, 2 Apr 2014 23:18:16 -0700 (PDT) +Received: from mx4.nic.fr (mx4.nic.fr [192.134.4.12]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 99D9F431FAE + for ; Wed, 2 Apr 2014 23:18:16 -0700 (PDT) +Received: from mx4.nic.fr (localhost [127.0.0.1]) + by mx4.nic.fr (Postfix) with SMTP id 6A23B2806C3; + Thu, 3 Apr 2014 08:18:15 +0200 (CEST) +Received: from relay2.nic.fr (relay2.nic.fr [192.134.4.163]) + by mx4.nic.fr (Postfix) with ESMTP id 649BC2806B9; + Thu, 3 Apr 2014 08:18:15 +0200 (CEST) +Received: from kaki.tech.prive.nic.fr (kaki.tech.prive.sqy.nic.fr + [10.10.86.114]) by relay2.nic.fr (Postfix) with ESMTP id 2975FB3800C; + Thu, 3 Apr 2014 08:17:45 +0200 (CEST) +Received: by kaki.tech.prive.nic.fr (Postfix, from userid 1000) + id 184193F8244; Thu, 3 Apr 2014 06:17:45 +0000 (UTC) +From: Kim Minh Kaplan +To: Tomi Ollila +Subject: Re: [Patch v5 3/6] util: add gz_readline +In-Reply-To: (Tomi Ollila's message of + "Wed, 02 Apr 2014 19:43:07 +0300") +References: <1396401381-18128-1-git-send-email-david@tethera.net> + <1396401381-18128-4-git-send-email-david@tethera.net> + <20140402032644.GB25677@mit.edu> +User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) +X-Face: C!5Mk_!qB]35}VpD|H>GN/@fk%~7:*/x8&~\]|r|)/zV?rJ){uX4Nh`a$L/z__Kx4Gt!mDU3kZlj)F2]Ds$?l'; + SO9]v^|[i2nY`pZ+mu+HT%5ITkuP#e]@8F4@Hc.=]oN1+d\M@Rl>-$C?h$yntf-JVx)3L2}VzG.!bQEy]~I_3fup`HtZ^t/Iz.|Vh$~o`^g\ +Date: Thu, 03 Apr 2014 06:17:44 +0000 +Message-ID: <87mwg32ayf.fsf@kaki.tech.prive.nic.fr> +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Transfer-Encoding: quoted-printable +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 03 Apr 2014 06:18:22 -0000 + +Tomi Ollila writes: + +> On Wed, Apr 02 2014, Austin Clements wrote: +> +>> Quoth David Bremner on Apr 01 at 10:16 pm: +>> +>>> + if (len =3D=3D 0 || buf =3D=3D NULL) { +>>> + /* same as getdelim from gnulib */ +>>> + len =3D 120; +>> +>> This is presumably because glibc's malloc has an 8 byte header. Fun +>> fact: talloc has a 104 byte header (on 64-bit and including the malloc +>> header). +> +> hmm, what should we choose here? 152 ? Some bikeshedding on IRC ? + +When your done with this bikeshed, do not forget the other one=C2=A0: + +>>> + len *=3D 2; + +--=20 +Kim Minh. -- 2.26.2