From fce73639914d5f9e1a199eed639b89992228fe04 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Sat, 13 Jun 2015 09:08:07 +0100 Subject: [PATCH] [PATCH v5 0/3] Add filter to emacs show mode --- 4a/363b030439857b921fd8702ca825af88ca6fc1 | 100 ++++++++++++++++++++++ 1 file changed, 100 insertions(+) create mode 100644 4a/363b030439857b921fd8702ca825af88ca6fc1 diff --git a/4a/363b030439857b921fd8702ca825af88ca6fc1 b/4a/363b030439857b921fd8702ca825af88ca6fc1 new file mode 100644 index 000000000..cdc32549c --- /dev/null +++ b/4a/363b030439857b921fd8702ca825af88ca6fc1 @@ -0,0 +1,100 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 04B9B6DE0C51 + for ; Sat, 13 Jun 2015 01:08:20 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.863 +X-Spam-Level: +X-Spam-Status: No, score=0.863 tagged_above=-999 required=5 tests=[AWL=0.433, + DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, + FREEMAIL_REPLY=1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, + RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id iOyiFIZQx7Po for ; + Sat, 13 Jun 2015 01:08:18 -0700 (PDT) +Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com + [209.85.212.176]) + by arlo.cworth.org (Postfix) with ESMTPS id D72986DE0350 + for ; Sat, 13 Jun 2015 01:08:17 -0700 (PDT) +Received: by wibut5 with SMTP id ut5so34351155wib.1 + for ; Sat, 13 Jun 2015 01:08:16 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:cc:subject:date:message-id; + bh=AuK/HWZCAdf9DUcVTLpVUE1kdzlu90Bcv4StKPfwLTo=; + b=WkwTZQKm2LbLp4kcvN/FLQy1R++Y3s8eJWEq+/H+yaZ96AxAfzMSRIm4PUAl7lZsZ/ + eyVPYveOqAssWssPni5M78+ri/23c6Muyutef3CkqXHYEUppmvNK4a5Z4hKBar0fQRRS + omyzCHWDEdvp4ju20NqZR+e72G8k91oaHqtNyEg2BCekYeLDrZ8PESQ8Z4MrCW/wSDSL + JYzpSjlVzLGtnzMBtIg7q8kol9NkySizXV9UAnJpkDfXLS2y7BJk5IXe6TEvg3gw5wne + Sg+wnVL5XYMLvbKA+IEKMHkZrRrCkrnyiOIxtyxV/KiAVf7i2BsdTuTsPAYuTYEyYGxW + 4w4w== +X-Received: by 10.180.87.201 with SMTP id ba9mr13679377wib.73.1434182896216; + Sat, 13 Jun 2015 01:08:16 -0700 (PDT) +Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162]) + by mx.google.com with ESMTPSA id qq1sm4624473wjc.0.2015.06.13.01.08.15 + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Sat, 13 Jun 2015 01:08:15 -0700 (PDT) +From: Mark Walters +To: notmuch@notmuchmail.org +Subject: [PATCH v5 0/3] Add filter to emacs show mode +Date: Sat, 13 Jun 2015 09:08:07 +0100 +Message-Id: <1434182890-8047-1-git-send-email-markwalters1009@gmail.com> +X-Mailer: git-send-email 2.1.4 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 13 Jun 2015 08:08:20 -0000 + +The previous version of this patch was over 3 years ago at +id:1335658006-20161-1-git-send-email-markwalters1009@gmail.com + +The reason the patch stopped was that it marked messages read (removed +the unread tag) spuriously (see Austin's review +id:20120429005736.GK2704@mit.edu) and this was difficult to +fix. However, now the unread handling has been updated this is no +longer a problem. (More precisely, since the unread handling is done +in the command loop hook the unread tag only gets updated after +notmuch has displayed the final result.) + +There are two small questions with this version that I would +appreciate views on. First it binds the filter/limit to l since f is +already bound to forward in show mode. It changes the binding in +search mode to match but that may annoy a lot of people who have got f +for filter into muscle memory. If we prefer to leave the keybinding in +search mode as it is then we can just drop the final patch. + +Secondly what should the behaviour be if the user just gives and empty +filter query? This patch just opens all messages in the thread (ie it +treats the query as matching everything). Alternatively, it could just +exit without refreshing the buffer in that case. + +Best wishes + +Mark + + +Mark Walters (3): + emacs: split notmuch-show-apply-state + emacs: add a filter option to show + emacs: Bind filter in search to 'l' + + emacs/notmuch-show.el | 30 +++++++++++++++++++++++------- + emacs/notmuch.el | 4 ++-- + 2 files changed, 25 insertions(+), 9 deletions(-) + +-- +2.1.4 + -- 2.26.2