From fcb226e6e32fdc340b88bc984551ab8a0fbb4e50 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Fri, 1 Jan 2016 13:39:21 +2000 Subject: [PATCH] Re: [PATCH 3/5] nmbug-status: Add an nmbug-status(5) man page --- 04/2da1d1a0e15cc76252cfe5de11df9af761a35e | 75 +++++++++++++++++++++++ 1 file changed, 75 insertions(+) create mode 100644 04/2da1d1a0e15cc76252cfe5de11df9af761a35e diff --git a/04/2da1d1a0e15cc76252cfe5de11df9af761a35e b/04/2da1d1a0e15cc76252cfe5de11df9af761a35e new file mode 100644 index 000000000..f54de308e --- /dev/null +++ b/04/2da1d1a0e15cc76252cfe5de11df9af761a35e @@ -0,0 +1,75 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id A82916DE191A + for ; Thu, 31 Dec 2015 09:39:30 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.311 +X-Spam-Level: +X-Spam-Status: No, score=-0.311 tagged_above=-999 required=5 tests=[AWL=0.240, + RP_MATCHES_RCVD=-0.55, SPF_PASS=-0.001] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id AS_i9mp6KYNO for ; + Thu, 31 Dec 2015 09:39:28 -0800 (PST) +Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) + by arlo.cworth.org (Postfix) with ESMTPS id D001C6DE182F + for ; Thu, 31 Dec 2015 09:39:28 -0800 (PST) +Received: from remotemail by fethera.tethera.net with local (Exim 4.84) + (envelope-from ) + id 1aEhC0-0001Dc-18; Thu, 31 Dec 2015 12:39:16 -0500 +Received: (nullmailer pid 23887 invoked by uid 1000); + Thu, 31 Dec 2015 17:39:21 -0000 +From: David Bremner +To: Jani Nikula , "W. Trevor King" , + notmuch@notmuchmail.org +Subject: Re: [PATCH 3/5] nmbug-status: Add an nmbug-status(5) man page +In-Reply-To: <87ege26fi4.fsf@nikula.org> +References: + <0a1bd306cb2e306ff49d72b6d2466c1d4a0ade2b.1451502495.git.wking@tremily.us> + <87ege26fi4.fsf@nikula.org> +User-Agent: Notmuch/0.21+26~g9404723 (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Thu, 31 Dec 2015 13:39:21 -0400 +Message-ID: <87fuyi4iwm.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 31 Dec 2015 17:39:30 -0000 + +Jani Nikula writes: + +> On Wed, 30 Dec 2015, "W. Trevor King" wrote: +>> To describe the config file format, so folks don't have to dig through +>> NEWS or the nmbug-status source to get that information. +> +> Overall I approve of the series (though I did not do a thorough +> review). +> +> I am wondering about the man page though. I find it slightly confusing +> there would be a man page named after the tool describing just the +> config, but not the tool itself. + +For me it's a bit odd to have a man page for a tool we don't install by +default. Is it maybe time to "promote" nmbug-status to the notmuch- +namespace and install it by default? That would have to be somehow tied +to installing the python bindings; or else the script could just print a +helpful error message if the bindings are not found. + +This would also allow addressing Tomi's comment about testing, by adding +a couple of tests to the test suite. + +d -- 2.26.2