From fc9b6fddbf56b5ac3b9bb12ba3aeda8df0da1a5f Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Mon, 1 Jun 2015 12:02:54 +0300 Subject: [PATCH] Re: [PATCH] test: remove redundant 'file' command from gdb scripts. --- 7a/7c664fd9de055beda4dee8438d254a402e6ec7 | 90 +++++++++++++++++++++++ 1 file changed, 90 insertions(+) create mode 100644 7a/7c664fd9de055beda4dee8438d254a402e6ec7 diff --git a/7a/7c664fd9de055beda4dee8438d254a402e6ec7 b/7a/7c664fd9de055beda4dee8438d254a402e6ec7 new file mode 100644 index 000000000..40204ef1a --- /dev/null +++ b/7a/7c664fd9de055beda4dee8438d254a402e6ec7 @@ -0,0 +1,90 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 6D3126DE1774 + for ; Mon, 1 Jun 2015 02:03:22 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 1.023 +X-Spam-Level: * +X-Spam-Status: No, score=1.023 tagged_above=-999 required=5 tests=[AWL=0.371, + SPF_NEUTRAL=0.652] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id BGmek8TDcikp for ; + Mon, 1 Jun 2015 02:03:19 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by arlo.cworth.org (Postfix) with ESMTP id 78DBD6DE1640 + for ; Mon, 1 Jun 2015 02:03:19 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 368D310008E; + Mon, 1 Jun 2015 12:02:55 +0300 (EEST) +From: Tomi Ollila +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH] test: remove redundant 'file' command from gdb scripts. +In-Reply-To: <1433091554-31483-1-git-send-email-david@tethera.net> +References: <1433091554-31483-1-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.20+12~gf3d9440 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 01 Jun 2015 09:03:22 -0000 + +On Sun, May 31 2015, David Bremner wrote: + +> Quoting Debian bug 787341 +> +> It failed to build on arm64: the last ten tests in T070-insert +> failed. +> +> What's happening here is that GDB is segfaulting in response to +> the +> "file" command. GDB on arm64 can be a bit buggy. +> +> However, the "file" command is redundant here as GDB has already +> got +> the file from the --args on the command line. +> --- + +looks trivial enough to me... + +> test/T070-insert.sh | 1 - +> 1 file changed, 1 deletion(-) +> +> diff --git a/test/T070-insert.sh b/test/T070-insert.sh +> index 168345c..74f1955 100755 +> --- a/test/T070-insert.sh +> +++ b/test/T070-insert.sh +> @@ -191,7 +191,6 @@ for code in OUT_OF_MEMORY XAPIAN_EXCEPTION FILE_NOT_EMAIL \ +> READ_ONLY_DATABASE UPGRADE_REQUIRED; do +> gen_insert_msg +> cat < index-file-$code.gdb +> -file notmuch +> set breakpoint pending on +> break notmuch_database_add_message +> commands +> -- +> 2.1.4 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2