From f71aa5b6f36b71cd9551fbd690176e98268f10ff Mon Sep 17 00:00:00 2001 From: David Bremner Date: Sun, 6 Jul 2014 09:11:29 +2100 Subject: [PATCH] Re: [PATCH] build: check .git directory existence in srcdir (for out-of-tree builds) --- 1b/0a831f686c50569a12d6d04218470d89931bf7 | 67 +++++++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 1b/0a831f686c50569a12d6d04218470d89931bf7 diff --git a/1b/0a831f686c50569a12d6d04218470d89931bf7 b/1b/0a831f686c50569a12d6d04218470d89931bf7 new file mode 100644 index 000000000..497e2b7fa --- /dev/null +++ b/1b/0a831f686c50569a12d6d04218470d89931bf7 @@ -0,0 +1,67 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 027F6431FB6 + for ; Sat, 5 Jul 2014 05:13:00 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 49HHLKm-lU0N for ; + Sat, 5 Jul 2014 05:12:46 -0700 (PDT) +Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net + [87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id A90AE431FAF + for ; Sat, 5 Jul 2014 05:12:46 -0700 (PDT) +Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim + 4.72) (envelope-from ) + id 1X3Oon-0005in-LI; Sat, 05 Jul 2014 12:11:49 +0000 +Received: (nullmailer pid 31561 invoked by uid 1000); Sat, 05 Jul 2014 + 12:11:29 -0000 +From: David Bremner +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH] build: check .git directory existence in srcdir (for + out-of-tree builds) +In-Reply-To: <1399404928-15471-1-git-send-email-tomi.ollila@iki.fi> +References: <1399404928-15471-1-git-send-email-tomi.ollila@iki.fi> +User-Agent: Notmuch/0.18.1+22~gbf82697 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sat, 05 Jul 2014 09:11:29 -0300 +Message-ID: <874mywroni.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 05 Jul 2014 12:13:00 -0000 + +Tomi Ollila writes: + +> So that $(VERSION) and version.stamp uses the git-describe -based +> version data instead of the content of `version' file. +> +> For consistency also the git commands in Makefile[.local] target +> `verify-no-dirty-code' uses the git --git-dir=$srcdir/.git ... +> commands (inside ifeq($(IS_GIT),yes)). Attempting to make this +> target outside of the tree will fail in any case. + +This seems to work OK; I wondered if an alternate method of setting (and +exporting) GIT_DIR from the top level makefile would work as well, and +be less intrusive? + +d -- 2.26.2