From f55d6ff0fff602e2ad2da15622f46cfbea01de72 Mon Sep 17 00:00:00 2001
From: David Bremner <david@tethera.net>
Date: Tue, 7 Apr 2015 19:20:38 +0900
Subject: [PATCH] Re: [Patch v2 4/4] cli: add standard option processing to
 config and setup

---
 6a/84554ae6c5c1a7b498a802596de44391c996e0 | 70 +++++++++++++++++++++++
 1 file changed, 70 insertions(+)
 create mode 100644 6a/84554ae6c5c1a7b498a802596de44391c996e0

diff --git a/6a/84554ae6c5c1a7b498a802596de44391c996e0 b/6a/84554ae6c5c1a7b498a802596de44391c996e0
new file mode 100644
index 000000000..b22e68ea2
--- /dev/null
+++ b/6a/84554ae6c5c1a7b498a802596de44391c996e0
@@ -0,0 +1,70 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id A0F626DE1989
+ for <notmuch@notmuchmail.org>; Tue,  7 Apr 2015 03:22:27 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: 0.443
+X-Spam-Level: 
+X-Spam-Status: No, score=0.443 tagged_above=-999 required=5 tests=[AWL=0.443]
+ autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id 5yTA_CVGVWVX for <notmuch@notmuchmail.org>;
+ Tue,  7 Apr 2015 03:22:25 -0700 (PDT)
+Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net
+ [87.98.215.224])
+ by arlo.cworth.org (Postfix) with ESMTPS id 5DA6E6DE1950
+ for <notmuch@notmuchmail.org>; Tue,  7 Apr 2015 03:22:25 -0700 (PDT)
+Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim
+ 4.80) (envelope-from <david@tethera.net>)
+ id 1YfQcq-0000QS-QS; Tue, 07 Apr 2015 10:20:56 +0000
+Received: (nullmailer pid 25482 invoked by uid 1000); Tue, 07 Apr 2015
+ 10:20:38 -0000
+From: David Bremner <david@tethera.net>
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
+Subject: Re: [Patch v2 4/4] cli: add standard option processing to config and
+ setup
+In-Reply-To: <87vbh8qu2s.fsf@qmul.ac.uk>
+References: <87d23ixnr7.fsf@maritornes.cs.unb.ca>
+ <1428322958-2887-1-git-send-email-david@tethera.net>
+ <1428322958-2887-5-git-send-email-david@tethera.net>
+ <87vbh8qu2s.fsf@qmul.ac.uk>
+User-Agent: Notmuch/0.19+96~g703c8f9 (http://notmuchmail.org) Emacs/24.4.1
+ (x86_64-pc-linux-gnu)
+Date: Tue, 07 Apr 2015 19:20:38 +0900
+Message-ID: <87vbh8gryh.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.18
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Tue, 07 Apr 2015 10:22:27 -0000
+
+Mark Walters <markwalters1009@gmail.com> writes:
+
+>
+> Why "setup" here rather than argv[0] or similar? It seems inconsistent
+> with the other cases.
+>
+> Best wishes
+>
+> Mark
+
+You're right this deserves a comment. notmuch_setup_command is actually
+called with argv=NULL (hence the unused (char * argv). The argument
+types are constrained by the fact we use a table of function pointers to
+dispatch.
+
+d
-- 
2.26.2