From f4acd42e6a710e6a7128146f6914c86d1f824f01 Mon Sep 17 00:00:00 2001 From: David Edmondson Date: Sun, 3 Apr 2016 19:42:04 +0100 Subject: [PATCH] Re: (emacs) Parsing problems replying to encrypted html --- 57/3b5f49f3ee0185e5078476e4620abadf42fea9 | 142 ++++++++++++++++++++++ 1 file changed, 142 insertions(+) create mode 100644 57/3b5f49f3ee0185e5078476e4620abadf42fea9 diff --git a/57/3b5f49f3ee0185e5078476e4620abadf42fea9 b/57/3b5f49f3ee0185e5078476e4620abadf42fea9 new file mode 100644 index 000000000..9609b94cd --- /dev/null +++ b/57/3b5f49f3ee0185e5078476e4620abadf42fea9 @@ -0,0 +1,142 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 09B386DE0314 + for ; Sun, 3 Apr 2016 11:42:18 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.172 +X-Spam-Level: +X-Spam-Status: No, score=-0.172 tagged_above=-999 required=5 + tests=[AWL=-0.105, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, + RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, + RCVD_IN_MSPIKE_WL=-0.01, SPF_NEUTRAL=0.652, UNPARSEABLE_RELAY=0.001] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id rtqu_M-e3CVA for ; + Sun, 3 Apr 2016 11:42:09 -0700 (PDT) +Received: from mail-lf0-f54.google.com (mail-lf0-f54.google.com + [209.85.215.54]) + by arlo.cworth.org (Postfix) with ESMTPS id 33FBD6DE01C2 + for ; Sun, 3 Apr 2016 11:42:09 -0700 (PDT) +Received: by mail-lf0-f54.google.com with SMTP id g184so65241686lfb.3 + for ; Sun, 03 Apr 2016 11:42:09 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=dme-org.20150623.gappssmtp.com; s=20150623; + h=to:cc:subject:in-reply-to:references:from:date:message-id + :mime-version; bh=Vi4S2oWPnis1sOPPbCY3t+roanIZS7h0duYDSf1A0ls=; + b=OHHDANTlvVUCkTzdnwnwv6we+uAKcF8DVixuA6DNayj7xjvk76dMoFfsV46D2//gkG + o7mYajvR5lMjYdJRo5viZkSRNq180+Kj+25/FHFu8F8gYw8DZ5w+JwbgzD77+tBcqTEv + tm2dMTGDMGJd87ukXgmjRUsVEPZJcnIHB/V7ikjZnsBWFAPyKrjmTk/kHGqQJMKs1XJi + 1UJvQKRfRfsiMcAXE0GBHNvyL9vkJ6eWI3hIgBH6hwKWAHqq7FIRKIX0XU/0HKku+jQp + +cBozBZsQ2ul+QQRVi0zAtC/90qTnPnEnndXU7HHyfjGNwb+1NFt2Lz1eYEZ8gqFaGmC + 6Fsw== +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:to:cc:subject:in-reply-to:references:from:date + :message-id:mime-version; + bh=Vi4S2oWPnis1sOPPbCY3t+roanIZS7h0duYDSf1A0ls=; + b=LB5fJNepU3dZ9UknyWg+wE76syGrDQx5UmJHNAxjnnIQmcw4ThnrOLbbv2cFDI7cfP + i1QylK5Ozmt5jP6ORB1yf1kZKQThD/xZCwKOAccyP5N4oPCDDW4wIpZ5Dbok2da0Nb3Z + 0+URIfkwkI1hcLqV2uRUlnR6WCLVL1STlPZ8totQqkH5WPmFH/PHuuPj6HxpwKTNgSrV + Qf+ohB6ktkRriZKHgY5QNnycaTjnJ8/odegKX0P1aXDkBTOG2Et2kRIj5ZG6ChCnh/uN + 85IBdZ0gIRewzbADbxFzBNswpIKfSFfoztmWqkMM4NESDhYnqNfGtOLW2AHzDWJOQrFm + inYA== +X-Gm-Message-State: + AD7BkJLK+AnOGFf7wEzAcf92oNXc9/lJbx3driVPZF1Rqn9ZGmSNtlaw+o0f6EdqBnuoVw== +X-Received: by 10.194.90.229 with SMTP id bz5mr15387963wjb.143.1459708927434; + Sun, 03 Apr 2016 11:42:07 -0700 (PDT) +Received: from disaster-area.hh.sledj.net + ([2a01:348:1a2:1:ea39:35ff:fe2c:a227]) + by smtp.gmail.com with ESMTPSA id u145sm9935345wmu.17.2016.04.03.11.42.06 + (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Sun, 03 Apr 2016 11:42:06 -0700 (PDT) +Received: from localhost (disaster-area.hh.sledj.net [local]) + by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id a4b01762; + Sun, 3 Apr 2016 18:42:05 +0000 (UTC) +To: David Bremner , Matthew Lear +Cc: notmuch@notmuchmail.org, Mark Walters +Subject: Re: (emacs) Parsing problems replying to encrypted html +In-Reply-To: <87lh4wj4kq.fsf@zancas.localnet> +References: + + + <56DD48B3.90604@bubblegen.co.uk> <87mvqatr6y.fsf@zancas.localnet> + <87h9gigfyz.fsf@bubblegen.co.uk> <87pov58b9y.fsf@zancas.localnet> + <87wpp76ctq.fsf@zancas.localnet> + <87h9fm315q.fsf@bubblegen.co.uk> + <87oa9timv7.fsf@zancas.localnet> + <575b60a1d39a1ecc7d06e5c0d625be61.squirrel@webmail.plus.net> + <87bn5tjw5e.fsf@tesseract.cs.unb.ca> + <5ed42cd5aafdc045b5d9e1b918d10748.squirrel@webmail.plus.net> + <87mvpdgp38.fsf@bubblegen.co.uk> <87lh4wj4kq.fsf@zancas.localnet> +From: David Edmondson +Date: Sun, 03 Apr 2016 19:42:04 +0100 +Message-ID: +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 03 Apr 2016 18:42:18 -0000 + +On Sat, Apr 02 2016, David Bremner wrote: +> Matthew Lear writes: +> +>>>> Hmm. I can't duplicate the problem replying from show mode with the test +>>>> message you provided. Is the appropriate key in your gpg keyring? +>>> +>>> Yes it is. I get the gpg gui prompt when opening the encrypted email and +>>> can decrypt it prior to show. As I suspected earlier in the thread, I +>>> wondered if this was related to some emacs config settings/options that I +>>> have. I can't immediately think what they would be though, and why they +>>> would trigger this particular issue for html only. Strange... +>> +>> Do you have the following in your .emacs ? +>> +>> (setq notmuch-multipart/alternative-discouraged '("text/plain")) +>> +>> I think that's the work/not-work switch. I'm not sure if it makes sense +>> or not in terms of seeing the behaviour I do. +> +> OK, with that setting I can duplicate the problem replying to encrypted +> HTML mail. +> +> It's also true that notmuch-reply doesn't include the content in the +> html version of the multipart/alternative. Unlike notmuch show, it +> doesn't have the ability to send parts later, so I guess that's a +> problem there. +> +> The following patch seems to fix it for me. What I haven't worked out is +> if it will break other things. Perhaps David E or Mark (in copy) can +> comment on whether this is a sensible change, given that we now give the +> user control of showing the part on the emacs side. + +As an alternative, could you try the patch in +id:1459708823-1852-1-git-send-email-dme@dme.org? I think that this is +really a failure on the emacs side rather than in notmuch proper. + +> diff --git a/notmuch-reply.c b/notmuch-reply.c +> index 3c6d685..cd88d79 100644 +> --- a/notmuch-reply.c +> +++ b/notmuch-reply.c +> @@ -690,7 +690,7 @@ notmuch_reply_format_sprinter(void *ctx, +> +> /* Start the original */ +> sp->map_key (sp, "original"); +> - format_part_sprinter (ctx, sp, node, TRUE, TRUE, FALSE); +> + format_part_sprinter (ctx, sp, node, TRUE, TRUE, TRUE); +> +> /* End */ +> sp->end (sp); -- 2.26.2