From f49893d46d5121a28bc7b5f147bf2a123ec95515 Mon Sep 17 00:00:00 2001 From: David Edmondson Date: Fri, 2 May 2014 12:14:08 +0100 Subject: [PATCH] precedence in `notmuch-search-line-faces' --- 4c/6959f876b068496196789c38fba7cc1e98d4e0 | 106 ++++++++++++++++++++++ 1 file changed, 106 insertions(+) create mode 100644 4c/6959f876b068496196789c38fba7cc1e98d4e0 diff --git a/4c/6959f876b068496196789c38fba7cc1e98d4e0 b/4c/6959f876b068496196789c38fba7cc1e98d4e0 new file mode 100644 index 000000000..f01bd4ef8 --- /dev/null +++ b/4c/6959f876b068496196789c38fba7cc1e98d4e0 @@ -0,0 +1,106 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 143A5431FC0 + for ; Fri, 2 May 2014 04:14:31 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id KJT+rEAzYkTQ for ; + Fri, 2 May 2014 04:14:27 -0700 (PDT) +Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com + [209.85.212.169]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 12DD4431FB6 + for ; Fri, 2 May 2014 04:14:26 -0700 (PDT) +Received: by mail-wi0-f169.google.com with SMTP id hi5so2068993wib.0 + for ; Fri, 02 May 2014 04:14:24 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:to:subject:user-agent:from:date:message-id + :mime-version:content-type; + bh=hoYJVdFlZkBCLtvA8YPVo7UtgCYQd8FC/pz2FGBq3iM=; + b=QBGJCfmS7hRbG6lgdMiNAODwHHpAVjBeR9ctjTCluC8kFc5Dr4pB/1YumwltthFHSA + xSbFKfcFvaLUS9b+3RjOCB9CPzHJr9rpzJO9urG+UC3OQEPzZFn7WL3r5lgK7718+QmF + 3YCS2E9SJ8xjiFAZqX4BV4q9EPV09foEJdX2sElT7EshCs1049Ex8qrDF4QInpPOUFIp + 4ecd47qxyG+AxBdqJ9vSeRQtiHjnD6x7l6wcdUAKmvvxhbMNheB8hCa7YxkI5eNCOXi8 + P7VmgUboqtV1uarORjconAYRk89vh0afZFL+2c/9B8vuHokRC3qc6RUsQ+PU92qZzQsq + c19Q== +X-Gm-Message-State: + ALoCoQk/C7xM0Unu+v2CYsk3lXgRUEkZbg3Un5SYu2oL9ABSe59JipRowYVVK3NEHuUUQzmgtlUx +X-Received: by 10.180.12.206 with SMTP id a14mr2501177wic.48.1399029264532; + Fri, 02 May 2014 04:14:24 -0700 (PDT) +Received: from localhost ([2a01:348:1a2:1:a288:b4ff:fe8a:77d8]) + by mx.google.com with ESMTPSA id u1sm1665421wjx.16.2014.05.02.04.14.22 + for + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Fri, 02 May 2014 04:14:23 -0700 (PDT) +To: notmuch@notmuchmail.org +Subject: precedence in `notmuch-search-line-faces' +User-Agent: Notmuch/0.18~rc0 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +From: David Edmondson +Date: Fri, 02 May 2014 12:14:08 +0100 +Message-ID: +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha1; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 02 May 2014 11:14:31 -0000 + +--=-=-= +Content-Type: text/plain + +The documentation for `notmuch-search-line-faces' says: + +> The attributes defined for matching tags are merged, with later +> attributes overriding earlier. + +A comment in `notmuch-search-color-line', which implements this, says: + +> ;; Reverse the list so earlier entries take precedence + +Clearly these two are at odds. The implementation of +`notmuch-search-color-line' follows the comment. That is, earlier +entries in the list take precedence. + +The original implementation of `notmuch-search-color-line' followed the +documentation of the user-visible variable, but this was changed by +commit 60ebc849 in July 2012. + +I'm inclined to go with the documentation and change the implementation, +but this could obviously ruin things for some users until they reorder +their settings. + +Thoughts? + +--=-=-= +Content-Type: application/pgp-signature; name="signature.asc" + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1 + +iKYEARECAGYFAlNjfgBfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl +bnBncC5maWZ0aGhvcnNlbWFuLm5ldDc1M0Y5NDJDMEExNjc3MDE4OURGMUYyMDY5 +RUNEMEFCRjA0OTY1MTYACgkQaezQq/BJZRZPkACeIChJReHh21L4wlY6ODjTh0wm +kA8AoIK0MNrhgqLtWiA4oBja19iAsInt +=ZOgI +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2