From f29bcc59df128e7ca37ed324846ebb760ee13be8 Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Sat, 24 Nov 2012 23:57:05 -0500 Subject: [PATCH] lib: Add an iterator over all messages in a thread Previously, getting the list of all messages in a thread required recursively traversing the thread's message hierarchy, which was both difficult and resulted in messages being out of order. This adds a public function to retrieve an iterator over all of the messages in a thread in oldest-first order. --- lib/notmuch.h | 13 +++++++------ lib/thread.cc | 6 ++++++ 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/lib/notmuch.h b/lib/notmuch.h index 3633bedd..37393367 100644 --- a/lib/notmuch.h +++ b/lib/notmuch.h @@ -719,20 +719,21 @@ int notmuch_thread_get_total_messages (notmuch_thread_t *thread); /* Get a notmuch_messages_t iterator for the top-level messages in - * 'thread'. + * 'thread' in oldest-first order. * * This iterator will not necessarily iterate over all of the messages * in the thread. It will only iterate over the messages in the thread * which are not replies to other messages in the thread. - * - * To iterate over all messages in the thread, the caller will need to - * iterate over the result of notmuch_message_get_replies for each - * top-level message (and do that recursively for the resulting - * messages, etc.). */ notmuch_messages_t * notmuch_thread_get_toplevel_messages (notmuch_thread_t *thread); +/* Get a notmuch_thread_t iterator for all messages in 'thread' in + * oldest-first order. + */ +notmuch_messages_t * +notmuch_thread_get_messages (notmuch_thread_t *thread); + /* Get the number of messages in 'thread' that matched the search. * * This count includes only the messages in this thread that were diff --git a/lib/thread.cc b/lib/thread.cc index 45a7d1d0..c126aac8 100644 --- a/lib/thread.cc +++ b/lib/thread.cc @@ -508,6 +508,12 @@ notmuch_thread_get_toplevel_messages (notmuch_thread_t *thread) return _notmuch_messages_create (thread->toplevel_list); } +notmuch_messages_t * +notmuch_thread_get_messages (notmuch_thread_t *thread) +{ + return _notmuch_messages_create (thread->message_list); +} + const char * notmuch_thread_get_thread_id (notmuch_thread_t *thread) { -- 2.26.2