From f0fe14d7e966b646b5f83b102d9448ad69c00455 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Sun, 19 Oct 2014 12:53:19 +0300 Subject: [PATCH] Re: [PATCH] VIM: Make an option to save sent mail locally --- 46/7b274a782a462e801ad3aa18115555aa045e1a | 130 ++++++++++++++++++++++ 1 file changed, 130 insertions(+) create mode 100644 46/7b274a782a462e801ad3aa18115555aa045e1a diff --git a/46/7b274a782a462e801ad3aa18115555aa045e1a b/46/7b274a782a462e801ad3aa18115555aa045e1a new file mode 100644 index 000000000..51cf94a72 --- /dev/null +++ b/46/7b274a782a462e801ad3aa18115555aa045e1a @@ -0,0 +1,130 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 3C84F431FBF + for ; Sun, 19 Oct 2014 02:53:46 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id mrz72NNvojeF for ; + Sun, 19 Oct 2014 02:53:39 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 0798B431FB6 + for ; Sun, 19 Oct 2014 02:53:39 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id B63CC10008C; + Sun, 19 Oct 2014 12:53:19 +0300 (EEST) +From: Tomi Ollila +To: Ian Main , notmuch@notmuchmail.org +Subject: Re: [PATCH] VIM: Make an option to save sent mail locally +In-Reply-To: <5433693499518_7e54e45e9424@ovo.mains.priv.notmuch> +References: <1412617904-27252-1-git-send-email-imain@stemwinder.org> + <1412619036-29203-1-git-send-email-imain@stemwinder.org> + + <5433693499518_7e54e45e9424@ovo.mains.priv.notmuch> +User-Agent: Notmuch/0.18.1+130~ga61922f (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 19 Oct 2014 09:53:46 -0000 + +On Tue, Oct 07 2014, Ian Main wrote: + +> Tomi Ollila wrote: +>> On Mon, Oct 06 2014, Ian Main wrote: +>> +>> > Add an option to use 'notmuch insert' to save your sent mail. +>> > --- +>> > +>> > Add -inbox as well. +>> > +>> > vim/notmuch.vim | 17 +++++++++++++++++ +>> > 1 file changed, 17 insertions(+) +>> > +>> > diff --git a/vim/notmuch.vim b/vim/notmuch.vim +>> > index 331e930..a9044c4 100644 +>> > --- a/vim/notmuch.vim +>> > +++ b/vim/notmuch.vim +>> > @@ -58,6 +58,7 @@ let s:notmuch_date_format_default = '%d.%m.%y' +>> > let s:notmuch_datetime_format_default = '%d.%m.%y %H:%M:%S' +>> > let s:notmuch_reader_default = 'mutt -f %s' +>> > let s:notmuch_sendmail_default = 'sendmail' +>> > +let s:notmuch_save_sent_locally_default = 1 +>> > let s:notmuch_folders_count_threads_default = 0 +>> > +>> > function! s:new_file_buffer(type, fname) +>> > @@ -108,6 +109,18 @@ EOF +>> > echohl None +>> > return +>> > endif +>> +>> AFAIU looks mmm. readable ;) +>> +>> > + +>> > + if g:notmuch_save_sent_locally +>> > + let out = system('cat ' . fname . ' | notmuch insert --create-folder --folder=Sent +sent -unread -inbox') +>> +>> as this is (looks like) shell invocation, this could be in format +>> +>> let out = system('notmuch insert --create-folder --folder=Sent +sent -unread -inbox < ' . fname) +> +> You are right, that's better. +> +>> or even +>> +>> let out = system('exec notmuch insert --create-folder --folder=Sent +sent -unread -inbox < ' . fname) +>> +>> (well, the latter would be out of the status quo) +>> +>> Ok, I looked a bit into the notmuch.vim -code, and noticed sometimes +>> system() command lines use "notmuch" and sometimes g:notmuch_cmd +>> -- I think the latter should be used in new code and the previous ones +>> should be fixed. +>> +>> i.e. system ( g:notmuch_cmd . ' insert ... ' < . fname) +>> +>> Totally untested from my part... +>> +>> When the change alike this lands to the notmuch repository this needs NEWS +>> item which informs that from now sent mails are notmuch-inserted to +>> user's mail store (as this seems to be the default...) -- well, let's see +>> that when there are real reviewers (i.e. those who are interested to and can +>> test this). +> +> Also a good suggestion. From what I see they always use 'notmuch' straight up +> which is probably a reasonable assumption. I do think the actual init code for +> vim could have a few more checks, such as verifying that 'notmuch' is in $PATH +> etc. +> +> Thanks for the review!! I'll send out a new rev tomorrow - very tired +> right now. + +I never seen the new rev... :D + +> +> Ian + +Tomi -- 2.26.2