From f04824a782a688d1b5ca28a3d75dade3f08c19da Mon Sep 17 00:00:00 2001 From: Daniel Kahn Gillmor Date: Sat, 12 Dec 2015 23:10:19 +1900 Subject: [PATCH] Re: [PATCH 7/9] add a gpg_path value for notmuch_database_t --- a1/435687c088c073ab493009dc6bfe6f6ae8174f | 66 +++++++++++++++++++++++ 1 file changed, 66 insertions(+) create mode 100644 a1/435687c088c073ab493009dc6bfe6f6ae8174f diff --git a/a1/435687c088c073ab493009dc6bfe6f6ae8174f b/a1/435687c088c073ab493009dc6bfe6f6ae8174f new file mode 100644 index 000000000..7bfb9b3e5 --- /dev/null +++ b/a1/435687c088c073ab493009dc6bfe6f6ae8174f @@ -0,0 +1,66 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 4C8456DE0A9A + for ; Fri, 11 Dec 2015 20:10:25 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.014 +X-Spam-Level: +X-Spam-Status: No, score=-0.014 tagged_above=-999 required=5 + tests=[AWL=-0.014] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id VCAIMLToXUaC for ; + Fri, 11 Dec 2015 20:10:23 -0800 (PST) +Received: from che.mayfirst.org (che.mayfirst.org [209.234.253.108]) + by arlo.cworth.org (Postfix) with ESMTP id 633F06DE005F + for ; Fri, 11 Dec 2015 20:10:23 -0800 (PST) +Received: from fifthhorseman.net (unknown [38.109.115.130]) + by che.mayfirst.org (Postfix) with ESMTPSA id 8EA42F984; + Fri, 11 Dec 2015 23:10:19 -0500 (EST) +Received: by fifthhorseman.net (Postfix, from userid 1000) + id 19AB920001; Fri, 11 Dec 2015 23:10:19 -0500 (EST) +From: Daniel Kahn Gillmor +To: "J. Lewis Muir" , + Notmuch Mail +Subject: Re: [PATCH 7/9] add a gpg_path value for notmuch_database_t +In-Reply-To: <566B4FCE.30802@imca-cat.org> +References: <1449718786-28000-1-git-send-email-dkg@fifthhorseman.net> + <1449718786-28000-8-git-send-email-dkg@fifthhorseman.net> + <566B4FCE.30802@imca-cat.org> +User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Fri, 11 Dec 2015 23:10:19 -0500 +Message-ID: <87h9jofgt0.fsf@alice.fifthhorseman.net> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 12 Dec 2015 04:10:25 -0000 + +On Fri 2015-12-11 17:35:58 -0500, J. Lewis Muir wrote: +> I guess I still don't get it. Why even have a _find_in_path function? +> Why not just expect the gpg executable path to have already been +> specified somehow (e.g. Notmuch configuration file, build-time constant, +> or environment variable)? + +This is happening in the library, which doesn't read the config file, +and doesn't depend on the environment. if a user tells the library "use +this as your gpg executable", it seems nice to fail early for them. + +It's also nice if we want to have a default that says something like +"use gpg2 if it's available, but gpg otherwise". + + --dkg -- 2.26.2