From efff0308500323722365d49274a5038833440dd7 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Wed, 23 Jul 2014 06:44:52 +2100 Subject: [PATCH] Re: Bug#755544: notmuch-emacs: doesn't check gpg/pgp signatures by default --- b0/f82bc677739e0cedbff2d97baf09c00918e43c | 84 +++++++++++++++++++++++ 1 file changed, 84 insertions(+) create mode 100644 b0/f82bc677739e0cedbff2d97baf09c00918e43c diff --git a/b0/f82bc677739e0cedbff2d97baf09c00918e43c b/b0/f82bc677739e0cedbff2d97baf09c00918e43c new file mode 100644 index 000000000..a27152130 --- /dev/null +++ b/b0/f82bc677739e0cedbff2d97baf09c00918e43c @@ -0,0 +1,84 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1AB28431FAF + for ; Tue, 22 Jul 2014 02:45:45 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id OsiDTdfwQ4ap for ; + Tue, 22 Jul 2014 02:45:37 -0700 (PDT) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 65A0C431FAE + for ; Tue, 22 Jul 2014 02:45:21 -0700 (PDT) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1X9Wd2-0003dA-1t; Tue, 22 Jul 2014 06:45:00 -0300 +Received: (nullmailer pid 19800 invoked by uid 1000); Tue, 22 Jul 2014 + 09:44:52 -0000 +From: David Bremner +To: Jameson Graef Rollins , Vagrant Cascadian + , 755544@bugs.debian.org +Subject: Re: Bug#755544: notmuch-emacs: doesn't check gpg/pgp signatures by + default +In-Reply-To: <87iomqxkzp.fsf@servo.finestructure.net> +References: <20140721223426.GA5250@siren> + <87silucnfx.fsf@maritornes.cs.unb.ca> + <87iomqxkzp.fsf@servo.finestructure.net> +User-Agent: Notmuch/0.18.1+45~gf47eeac (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Tue, 22 Jul 2014 06:44:52 -0300 +Message-ID: <878unlenhn.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 22 Jul 2014 09:45:45 -0000 + +Jameson Graef Rollins writes: + +> On Mon, Jul 21 2014, David Bremner wrote: +>> notmuch folks: it seems that in vagrant's message, and several others I +>> checked, it notmuch-crypto-process-mime==nil, then no signature button +>> is created at all. +> +> Yes, this is true. The signature button is pretty meaningless if we're +> not processing the signature. +> +> Maybe instead by default we could have a signature button that opens up +> a notmuch-crypto-process-mime customization buffer? +> +> jamie. + +looking at the source, there is supposed to be some button: + +,---- +| (defun notmuch-show-insert-part-multipart/signed (msg part content-type nth depth button) +| (button-put button 'face 'notmuch-crypto-part-header) +| ;; add signature status button if sigstatus provided +| (if (plist-member part :sigstatus) +| (let* ((from (notmuch-show-get-header :From msg)) +| (sigstatus (car (plist-get part :sigstatus)))) +| (notmuch-crypto-insert-sigstatus-button sigstatus from)) +| ;; if we're not adding sigstatus, tell the user how they can get it +| (button-put button 'help-echo "Set notmuch-crypto-process-mime to process cryptographic MIME parts.")) +`---- -- 2.26.2