From ee77c7386f8edf1b9c62c8f16660a2e9efcec9b1 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Wed, 10 Feb 2016 10:28:24 +0200 Subject: [PATCH] Re: [Gaudenz Steinlin] Bug#810784: should match email adress case insensitive when sending encrypted mail --- cc/47362c9a14d175321d860b9420bc2156a85513 | 87 +++++++++++++++++++++++ 1 file changed, 87 insertions(+) create mode 100644 cc/47362c9a14d175321d860b9420bc2156a85513 diff --git a/cc/47362c9a14d175321d860b9420bc2156a85513 b/cc/47362c9a14d175321d860b9420bc2156a85513 new file mode 100644 index 000000000..d9ee49a69 --- /dev/null +++ b/cc/47362c9a14d175321d860b9420bc2156a85513 @@ -0,0 +1,87 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 6EF306DE0231 + for ; Wed, 10 Feb 2016 00:28:07 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.644 +X-Spam-Level: +X-Spam-Status: No, score=0.644 tagged_above=-999 required=5 tests=[AWL=-0.008, + SPF_NEUTRAL=0.652] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 0R4vC9jRA6OH for ; + Wed, 10 Feb 2016 00:28:05 -0800 (PST) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by arlo.cworth.org (Postfix) with ESMTP id 5A26A6DE021E + for ; Wed, 10 Feb 2016 00:28:05 -0800 (PST) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 5EE7C10007F; + Wed, 10 Feb 2016 10:28:24 +0200 (EET) +From: Tomi Ollila +To: David Edmondson , + Daniel Kahn Gillmor , + David Bremner , Gaudenz Steinlin , + notmuch@notmuchmail.org, 810784@bugs.debian.org +Subject: Re: [Gaudenz Steinlin] Bug#810784: should match email adress case + insensitive when sending encrypted mail +In-Reply-To: +References: <87egdm4ujh.fsf@tesseract.cs.unb.ca> + <874mee7k88.fsf@alice.fifthhorseman.net> + + +User-Agent: Notmuch/0.21+32~g73439f8 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 10 Feb 2016 08:28:07 -0000 + +On Tue, Feb 09 2016, David Edmondson wrote: + +> On Mon, Feb 08 2016, David Edmondson wrote: +>> On Mon, Feb 08 2016, David Edmondson wrote: +>>> On Fri, Jan 15 2016, Daniel Kahn Gillmor wrote: +>>>> So where is the case-insensitive lookup happening? Is this a bug in +>>>> mml-mode, or in notmuch-emacs? +>>> +>>> It's caused by behaviour in mml2015.el (hence upstream). +>>> +>>> `mml2015-epg-check-user-id' uses `equal' to compare the recipient from +>>> the composition buffer with the addresses from the matching key. +>>> +>>> The simplest way to get the desired behaviour would be to `downcase' +>>> both strings before comparing. +>> +>> Reported as bug#22603 in emacs. +> +> Fixed in the emacs-25 branch. + +We could perhaps add defadvice to **wiki** for those who want to +do global change in their emacs environment, something like: + +(if (< emacs-major-version 25) + (defadvice mml2015-epg-check-user-id (around downcase activate) + (ad-set-arg 1 (downcase (ad-get-arg 1))) + (ad-set-arg 2 (downcase (ad-get-arg 2))) + ad-do-it)) + +totally untested -- also now that I finished that 'before might also work. -- 2.26.2