From ee5c3c660b6faf75f2937809c1340c49d50d825b Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Mon, 21 Apr 2014 23:26:14 +0300 Subject: [PATCH] Re: [PATCH 00/11] Improve charset and cid: handling --- 1b/aceecd17a779e3fbc3abca0f8845ab9a53f735 | 91 +++++++++++++++++++++++ 1 file changed, 91 insertions(+) create mode 100644 1b/aceecd17a779e3fbc3abca0f8845ab9a53f735 diff --git a/1b/aceecd17a779e3fbc3abca0f8845ab9a53f735 b/1b/aceecd17a779e3fbc3abca0f8845ab9a53f735 new file mode 100644 index 000000000..9e0424ab1 --- /dev/null +++ b/1b/aceecd17a779e3fbc3abca0f8845ab9a53f735 @@ -0,0 +1,91 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id B7778431FBF + for ; Mon, 21 Apr 2014 13:26:30 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id XItTH6wh9Zy0 for ; + Mon, 21 Apr 2014 13:26:23 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 8535C431FBD + for ; Mon, 21 Apr 2014 13:26:23 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 7407A10008C; + Mon, 21 Apr 2014 23:26:14 +0300 (EEST) +From: Tomi Ollila +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH 00/11] Improve charset and cid: handling +In-Reply-To: <1398105468-14317-1-git-send-email-amdragon@mit.edu> +References: <1398105468-14317-1-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.17+201~g56da2d6 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 21 Apr 2014 20:26:30 -0000 + +On Mon, Apr 21 2014, Austin Clements wrote: + +> I set out to quickly add support for cid: links in the shr renderer +> and wound up making our charset handling more robust and rewriting our +> content-ID handling. The test introduced in patch 2 passes in all but +> one really obscure case, but only because of many unwritten and +> potentially fragile assumptions that Emacs and the CLI make about each +> other. +> +> The first three patches could reasonably go in to 0.18. The rest of +> this series is certainly post-0.18, but I didn't want to lose track of +> it. + +Patches 1-3 looks good and tests pass. I've also (suffessfully) used +this 'no-conversion (although I don't remember why ;/ -- this conversion +stuff is not something simple to comprehend...) + +So, +1 for getting 1-3 to 0.18. + +Tomi + + +> +> This series comes in three stages. Each depends on the earlier ones, +> but each prefix makes sense on its own and could be pushed without the +> later stages. +> +> Patch 1 is a simple clean up patch. +> +> Patches 2 through 7 robust-ify our charset handling in Emacs, mostly +> by splitting the broken `notmuch-get-bodypart-content' API into +> `notmuch-get-bodypart-binary' and `notmuch-get-bodypart-text' so a +> caller can explicitly convey their requirements. +> +> The remaining patches improve our content-ID handling and add support +> for cid: links for shr. +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2