From ee2e2c057c5599eea7b74a85bdd995d546515f52 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Wed, 22 Jan 2014 21:32:45 +2000 Subject: [PATCH] [PATCH] test: make test_emacs call post-command-hook --- e0/ffd483a6c9b41f71fcf4c3a9a40294c9cc0b38 | 121 ++++++++++++++++++++++ 1 file changed, 121 insertions(+) create mode 100644 e0/ffd483a6c9b41f71fcf4c3a9a40294c9cc0b38 diff --git a/e0/ffd483a6c9b41f71fcf4c3a9a40294c9cc0b38 b/e0/ffd483a6c9b41f71fcf4c3a9a40294c9cc0b38 new file mode 100644 index 000000000..97002328e --- /dev/null +++ b/e0/ffd483a6c9b41f71fcf4c3a9a40294c9cc0b38 @@ -0,0 +1,121 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 28451431FBD + for ; Tue, 21 Jan 2014 17:33:06 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id pe+QB-haWx-g for ; + Tue, 21 Jan 2014 17:32:59 -0800 (PST) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id A231B431FAF + for ; Tue, 21 Jan 2014 17:32:59 -0800 (PST) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1W5mgc-0006Ys-Pa; Tue, 21 Jan 2014 21:32:58 -0400 +Received: (nullmailer pid 12484 invoked by uid 1000); Wed, 22 Jan 2014 + 01:32:55 -0000 +From: David Bremner +To: notmuch@notmuchmail.org +Subject: [PATCH] test: make test_emacs call post-command-hook +Date: Tue, 21 Jan 2014 21:32:45 -0400 +Message-Id: <1390354365-12311-1-git-send-email-david@tethera.net> +X-Mailer: git-send-email 1.8.5.2 +In-Reply-To: <1387064676-15508-6-git-send-email-markwalters1009@gmail.com> +References: <1387064676-15508-6-git-send-email-markwalters1009@gmail.com> +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 22 Jan 2014 01:33:06 -0000 + +From: Mark Walters + +The unread/read changes will use the post-command-hook. test_emacs +does not call the post-command-hook. This adds a notmuch-test-progn +which takes a list of commands as argument and executes them in turn +but runs the post-command-hook after each one. + +The caller can batch operations (ie to stop post-command-hook from +being interleaved) by wrapping the batch of operations inside a progn. + +We also explicitly run the post-command-hook before getting the output +from a test; this makes sense as this will be a place the user would +be seeing the information. +--- + +What do you think about this alternate version? it allows +notmuch-test-progn to have the same syntax as progn. It seems about +the same level of complexity to me; fwiw I prefer the let over the +dolist/setq. + + test/test-lib.el | 13 +++++++++++++ + test/test-lib.sh | 2 +- + 2 files changed, 14 insertions(+), 1 deletion(-) + +diff --git a/test/test-lib.el b/test/test-lib.el +index 37fcb3d..a12ad97 100644 +--- a/test/test-lib.el ++++ b/test/test-lib.el +@@ -52,11 +52,13 @@ + + (defun test-output (&optional filename) + "Save current buffer to file FILENAME. Default FILENAME is OUTPUT." ++ (notmuch-post-command) + (write-region (point-min) (point-max) (or filename "OUTPUT"))) + + (defun test-visible-output (&optional filename) + "Save visible text in current buffer to file FILENAME. Default + FILENAME is OUTPUT." ++ (notmuch-post-command) + (let ((text (visible-buffer-string))) + (with-temp-file (or filename "OUTPUT") (insert text)))) + +@@ -165,3 +167,14 @@ nothing." + + (t + (notmuch-test-report-unexpected output expected))))) ++ ++(defun notmuch-post-command () ++ (run-hooks 'post-command-hook)) ++ ++(defmacro notmuch-test-progn (&rest body) ++ (cons 'progn ++ (mapcar ++ (lambda (x) `(let ((ret ,x)) ++ (notmuch-post-command) ++ ret)) ++ body))) +diff --git a/test/test-lib.sh b/test/test-lib.sh +index 78af170..27dcb59 100644 +--- a/test/test-lib.sh ++++ b/test/test-lib.sh +@@ -1118,7 +1118,7 @@ test_emacs () { + rm -f OUTPUT + touch OUTPUT + +- ${TEST_EMACSCLIENT} --socket-name="$EMACS_SERVER" --eval "(progn $@)" ++ ${TEST_EMACSCLIENT} --socket-name="$EMACS_SERVER" --eval "(notmuch-test-progn $@)" + } + + test_python() { +-- +1.8.5.2 + -- 2.26.2