From edc6c34f5e64fca1653811f743d1db3bd569233a Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Mon, 17 Aug 2015 12:37:22 +0300 Subject: [PATCH] Re: [PATCH] cli/lib: remove support for GMime 2.4 --- f5/5839de641ab82a2e6251122c13d622a584d9c4 | 89 +++++++++++++++++++++++ 1 file changed, 89 insertions(+) create mode 100644 f5/5839de641ab82a2e6251122c13d622a584d9c4 diff --git a/f5/5839de641ab82a2e6251122c13d622a584d9c4 b/f5/5839de641ab82a2e6251122c13d622a584d9c4 new file mode 100644 index 000000000..2b4adb080 --- /dev/null +++ b/f5/5839de641ab82a2e6251122c13d622a584d9c4 @@ -0,0 +1,89 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id BBD436DE141E + for ; Mon, 17 Aug 2015 02:38:57 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 1.236 +X-Spam-Level: * +X-Spam-Status: No, score=1.236 tagged_above=-999 required=5 tests=[AWL=-0.160, + SPF_NEUTRAL=0.652, URIBL_SBL=0.644, URIBL_SBL_A=0.1] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 9nv1c-m1xwEF for ; + Mon, 17 Aug 2015 02:38:55 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by arlo.cworth.org (Postfix) with ESMTP id 770CC6DE0B26 + for ; Mon, 17 Aug 2015 02:38:55 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 476D11000CA; + Mon, 17 Aug 2015 12:37:22 +0300 (EEST) +From: Tomi Ollila +To: Daniel Kahn Gillmor , + David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH] cli/lib: remove support for GMime 2.4 +In-Reply-To: <874mjygvyb.fsf@alice.fifthhorseman.net> +References: <1439739201-11068-1-git-send-email-david@tethera.net> + <874mjygvyb.fsf@alice.fifthhorseman.net> +User-Agent: Notmuch/0.20.2+61~g1eba370 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 17 Aug 2015 09:38:57 -0000 + +On Mon, Aug 17 2015, Daniel Kahn Gillmor wrote: + +> On Sun 2015-08-16 21:53:36 +0200, Tomi Ollila wrote: +>> On Sun, Aug 16 2015, David Bremner wrote: +>> +>>> It's becoming a maintenance burden to do anything things with the +>>> crypto glue code twice, once for 2.4 and once for 2.6. I don't have +>>> any 2.4 version available to test on my development machine anymore, +>>> so the 2.4 specific code paths are likely not very well tested. +>>> --- +>>> +>>> I started to rebase the SMIME signature verification patches and got +>>> aggravated at solving the same conflicts twice in every file. +>>> +>>> 2.6.7 is from 2012, so that's a bit newer than some of our +>>> requirements, but I think not so bad. YMMV. +>> +>> Perhaps it is time for me to update to gmime 2.6 in this machine. PITA ;/ +> +> Please do, i think gmime 2.4 is really not well-supported upstream any +> more either. + +Hmm, it seems I've been using gmime 2.6(.17 -- now updated to .20) a long +time already -- just that `make distclean` does not see that and I've +been looking that part in my build script... + +Interestingly when David's changes are pushed I have to edit the distclean +part of my build to find new gmime so it can do that (distclean, that is) +successfully ;) + +IMO it is somewhat akward that `make distclean` executes `./configure` +but that is probably something no-one wants to do anything with... + +Tomi + +> +> --dkg -- 2.26.2