From eb65410e7520e6d09130a8591d886595219d73e4 Mon Sep 17 00:00:00 2001 From: "https://id.koumbit.net/anarcat" Date: Sat, 3 Mar 2012 00:19:17 -0400 Subject: [PATCH] move plugins/recentchangesdiff/Discussion here --- ...provide_inline_diffs_in_recentchanges.mdwn | 23 ++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/doc/todo/provide_inline_diffs_in_recentchanges.mdwn b/doc/todo/provide_inline_diffs_in_recentchanges.mdwn index 39a35d0c6..fe7eb1014 100644 --- a/doc/todo/provide_inline_diffs_in_recentchanges.mdwn +++ b/doc/todo/provide_inline_diffs_in_recentchanges.mdwn @@ -1,8 +1,29 @@ It would rock if I could view diffs from the web without going via feeds. I envision toggle-style buttons on the recentchanges page, or just links to the CGI, which then displays the diff... --[[madduck]] -> The diffs are actually there, enabled by the `recentchangesdiff` +> The diffs are actually there, enabled by the [[plugins/recentchangesdiff]] > plugin, but they are hidden in the XHTML version by the stylesheet. > You might try a user stylesheet with `div.diff { display: block }`. > --[[JasonBlevins]] +> > couldn't the diff be displayed as a popup? right now it's too bad because the diff is actually in the page, generated and downloaded, but the user can't see it. I have tried to address the issue by adding stuff to the change.tmpl template, but I may be missing something - and it doesn't quite look right: +> > +> > --- /usr/share/ikiwiki/templates/change.tmpl 2011-09-05 15:14:19.000000000 -0400 +> > +++ templates/change.tmpl 2011-10-11 13:04:37.704346964 -0400 +> > @@ -39,6 +39,7 @@ +> > +> > +> > +> > +[[show diff|wikiicons/diff.png]] +> >
+> > 
+> >      
+> > 
+> > There are a few things wrong with this:
+> > 
+> >  1. I don't like the hardcoded javascript in there, we should use [[plugins/toggle]] or something, but i am not sure how to make the this plugin depend on toggle, or if it is desirable. 
+> >  2. it doesn't work at all: first it doesn't actually "toggle" and second the javascript somehow gets filtered out of the resulting HTML so we don't even see it
+> >  3. if the diffurl parameter is set in the template, we'd actually see two sets of glasses, which is silly. i tried moving the diff button upwards into the PAGES loop, but there the diffurls are file-specific, which also seem quite silly
+> > 
+> > I am looking for guidance on how to improve and fix this now. --[[anarcat]] 2011-10-11
+
 [[!tag wishlist]]
-- 
2.26.2