From eb3a866e26ee85d090cb27d0240027490a1fe2d1 Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Sat, 2 Aug 2014 14:55:05 +2000 Subject: [PATCH] Re: [PATCH] Add configurable changed tag to messages that have been changed on disk --- 4b/a0a7254234ff559a5b73249e7af01d740818fa | 144 ++++++++++++++++++++++ 1 file changed, 144 insertions(+) create mode 100644 4b/a0a7254234ff559a5b73249e7af01d740818fa diff --git a/4b/a0a7254234ff559a5b73249e7af01d740818fa b/4b/a0a7254234ff559a5b73249e7af01d740818fa new file mode 100644 index 000000000..72dd25ff7 --- /dev/null +++ b/4b/a0a7254234ff559a5b73249e7af01d740818fa @@ -0,0 +1,144 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 168FB431FB6 + for ; Fri, 1 Aug 2014 11:55:22 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id UJQcGPWDr0cg for ; + Fri, 1 Aug 2014 11:55:14 -0700 (PDT) +Received: from dmz-mailsec-scanner-4.mit.edu (dmz-mailsec-scanner-4.mit.edu + [18.9.25.15]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id DC515431FAE + for ; Fri, 1 Aug 2014 11:55:13 -0700 (PDT) +X-AuditID: 1209190f-f79f86d0000061c8-85-53dbe28ff1a4 +Received: from mailhub-auth-1.mit.edu ( [18.9.21.35]) + (using TLS with cipher AES256-SHA (256/256 bits)) + (Client did not present a certificate) + by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP + id 96.74.25032.F82EBD35; Fri, 1 Aug 2014 14:55:11 -0400 (EDT) +Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) + by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id s71It9oC004322; + Fri, 1 Aug 2014 14:55:09 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id s71It6sD003929 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); + Fri, 1 Aug 2014 14:55:07 -0400 +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80) + (envelope-from ) + id 1XDHyr-0006oX-To; Fri, 01 Aug 2014 14:55:05 -0400 +Date: Fri, 1 Aug 2014 14:55:05 -0400 +From: Austin Clements +To: notmuch@notmuchmail.org +Subject: Re: [PATCH] Add configurable changed tag to messages that have been + changed on disk +Message-ID: <20140801185505.GS13893@mit.edu> +References: <1396800683-9164-1-git-send-email-eg@gaute.vetsj.com> + <87fviiiuzn.fsf@maritornes.cs.unb.ca> + +MIME-Version: 1.0 +Content-Type: text/plain; charset=iso-8859-1 +Content-Disposition: inline +Content-Transfer-Encoding: 8bit +In-Reply-To: + +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFtrFKsWRmVeSWpSXmKPExsUixCmqrNv/6Hawwb3fahY3WrsZLbZ2vGC2 + aPp8idXi+s2ZzBb7+v0dWD1+/Gtm83i26hazx5RZc9k9+r9cY/fYcug9cwBrFJdNSmpOZllq + kb5dAlfGwUNnWQtaxCrmLZ3G2sB4X6CLkZNDQsBEYt3C/6wQtpjEhXvr2boYuTiEBGYzSbyb + 94gRwtnAKNG34hZU5hSTxLnrr1khnCWMEgv/fWEG6WcRUJGY9uUW2Cw2AQ2JbfuXM4LYIgLS + EjvvzgaLMwssZZSY2CMPYgsLxElMu7yDCcTmFdCRuLj4Ozvcus3TetggEoISJ2c+YYFo1pHY + ufUOUJwDyJaWWP6PAyIsL9G8dTbYDZwCgRLHNmwCs0WB7plychvbBEbhWUgmzUIyaRbCpFlI + Ji1gZFnFKJuSW6Wbm5iZU5yarFucnJiXl1qka6KXm1mil5pSuokRHEWS/DsYvx1UOsQowMGo + xMNrsO92sBBrYllxZe4hRkkOJiVRXrOHQCG+pPyUyozE4oz4otKc1OJDjBIczEoivNu2AeV4 + UxIrq1KL8mFS0hwsSuK8b62tgoUE0hNLUrNTUwtSi2CyMhwcShK8DMBkISRYlJqeWpGWmVOC + kGbi4AQZzgM0fBrIYt7igsTc4sx0iPwpRkUpcd6tD4ASAiCJjNI8uF5YknvFKA70ijDvJZB2 + HmCChOt+BTSYCWhwjSHY4JJEhJRUA2PWXi3zP8f6N1ier47ukUuN0OTt+Vf0LUWLx1L3m0LS + hrZDmlv+MtieO/xW9GihY62mNe+svfp9xxSnvOcUl57ScH3qpWX7HhtoKui4sSvNMhQXc1+i + NVnIXGGfAQvrtGNnhPymz+n98SWSy3nd/qVf8/09Km+XVZWVNdUqvLvj8pxxotWiY0osxRmJ + hlrMRcWJAO+IU5lNAwAA +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 01 Aug 2014 18:55:22 -0000 + +I have a prototype implementation of message modification times on my +lastmod-v1 branch at + + https://github.com/aclements/notmuch/tree/lastmod-v1 + +It builds on my database features series that's currently awaiting +review [1]. + +The series uses a monotonic revision number, rather than wall-clock +time, for reasons related to Xapian's concurrent control and detailed +in the main commit's commit message. The implementation isn't quite +useful from the CLI yet because I haven't added any way to query the +database's current revision number. (I'm still thinking about how I +want to do this, since search/show don't have a good way to deliver +"additional" information right now. I might just add the last +modification for each individual message/max of all messages in a +thread, similar to what Thomas Jost's patch did long ago.) + +[1] id:1406859003-11561-1-git-send-email-amdragon@mit.edu + +Quoth Gaute Hope on Jul 28 at 4:37 pm: +> On Thu, Jul 3, 2014 at 12:42 PM, David Bremner <[1]david@tethera.net> +> wrote: +> +> Gaute Hope <[2]eg@gaute.vetsj.com> writes: +> +> > When one of the source files for a message is changed on disk, +> renamed, +> > deleted or a new source file is added. A configurable changed tag is +> > is added. The tag can be configured under the option 'changed_tags' in +> > the [new] section, the default is none. Tests have been updated to +> > accept the new config option. +> > +> > notmuch-setup now asks for a changed tag after the new tags question. +> > +> > This could be useful for for example 'afew' to detect remote changes +> in +> > IMAP folders and update the FolderNameFilter to also add tags or +> remove +> > tags when a _existing_ message has been added to or removed from a +> > maildir. +> +> The discussion on this proposal seems to have died out without reaching +> a conclusion. David M expressed a strong preference for some kind of +> modification time field in the database.  Gaute agreed with some caveats +> that such an approach could solve his problems as well. On the other +> hand, nobody seems to be actually working on such an approach at the +> moment.  Gaute and or David do you have any interest in revisiting the +> series [3]id:1323796305-28789-1-git-send-email-schnouki@schnouki.net and +> seeing if it can be reworked into mergeable shape? I suspect in +> particular something needs to be added with respect to message deletion +> Thomas, are you still running some variant of these patches? +> d +> +> I am afraid I don't have the chance to put in any consistent effort on +> this at the moment. +> +> I agree, message deletion needs to be solved somehow. +> Regards, Gaute -- 2.26.2