From ea415d6a255423f8f69b52a522216c35b9f79dc0 Mon Sep 17 00:00:00 2001 From: Eric Date: Mon, 27 Jan 2014 15:55:49 +0000 Subject: [PATCH] Re: Bug: notmuch new chokes on dangling symlinks and quits --- 4f/0a19a8eeaa13959760bb0e69b6d8d352c7f6b6 | 104 ++++++++++++++++++++++ 1 file changed, 104 insertions(+) create mode 100644 4f/0a19a8eeaa13959760bb0e69b6d8d352c7f6b6 diff --git a/4f/0a19a8eeaa13959760bb0e69b6d8d352c7f6b6 b/4f/0a19a8eeaa13959760bb0e69b6d8d352c7f6b6 new file mode 100644 index 000000000..74276dc2b --- /dev/null +++ b/4f/0a19a8eeaa13959760bb0e69b6d8d352c7f6b6 @@ -0,0 +1,104 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1B36C431FBC + for ; Mon, 27 Jan 2014 09:07:27 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id GdsGa-AaDo84 for ; + Mon, 27 Jan 2014 09:07:20 -0800 (PST) +X-Greylist: delayed 4288 seconds by postgrey-1.32 at olra; + Mon, 27 Jan 2014 09:07:20 PST +Received: from earth.solardns.com (earth.solardns.com [94.76.229.85]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 6A1A4431FBD + for ; Mon, 27 Jan 2014 09:07:20 -0800 (PST) +Received: from cpc1-finc12-2-0-cust846.4-2.cable.virginm.net + ([82.18.251.79]:56145 helo=teckel.deptj.eu) + by earth.solardns.com with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) + (Exim 4.82) (envelope-from ) id 1W7oXN-0002vd-OH + for notmuch@notmuchmail.org; Mon, 27 Jan 2014 15:55:49 +0000 +Received: from eric by teckel.deptj.eu with local (Exim 4.71) + (envelope-from ) id 1W7oXN-000601-18 + for notmuch@notmuchmail.org; Mon, 27 Jan 2014 15:55:49 +0000 +Date: Mon, 27 Jan 2014 15:55:49 +0000 +Message-Id: +From: Eric +Subject: Re: Bug: notmuch new chokes on dangling symlinks and quits +To: notmuch +In-Reply-To: <20140127011427.GD10844@boo.workgroup> +References: <20140126131846.GA10844@boo.workgroup> + <878uu2n17j.fsf@zancas.localnet> + <20140127011427.GD10844@boo.workgroup> +X--MailScanner-Information: Please contact the ISP for more information +X--MailScanner-ID: 1W7oXN-0002vd-OH +X--MailScanner: Not scanned: please contact your Internet E-Mail Service + Provider for details +X--MailScanner-SpamCheck: +X--MailScanner-From: eric@deptj.eu +X-AntiAbuse: This header was added to track abuse, + please include it with any abuse report +X-AntiAbuse: Primary Hostname - earth.solardns.com +X-AntiAbuse: Original Domain - notmuchmail.org +X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] +X-AntiAbuse: Sender Address Domain - deptj.eu +X-Get-Message-Sender-Via: earth.solardns.com: authenticated_id: deptjeu/from_h +X-Source: +X-Source-Args: +X-Source-Dir: +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 27 Jan 2014 17:07:27 -0000 + +On Mon, 27 Jan 2014 02:14:27 +0100, Gregor Zattler wrote: +> Hi David, +> * David Bremner [26. Jan. 2014]: +> > Gregor Zattler writes: +> >> I consider this to be a bug. Instead notmuch should simply +> >> ignore the symlink. +> >> +> > +> > Since there is a test for specifically this behaviour, I'd have to say +> > it's a design decision you don't agree with, not a bug ;). +> +> May I ask why this is so? + +I have no idea what went on with such a decision, but, from the outside: + +1) A dangling symlink should probably be handled in the same way as + an unreadable file, but would need a separate test because it is + a separate condition. + +2) A dangling symlink should not be a normal condition anywhere, why do + you have them? + +3) I am even more amazed that there should be a dangling symlink in a + Maildir tree. +> +> > In any case, if there is just a few broken symlinks, and you want to +> > ignore them, you can add them the ignore= line in .notmuch-config +> +> Thanks, I deleted some, and ignored others. Insofar my problem is +> solved. + +Eric +-- +ms fnd in a lbry -- 2.26.2