From e9af1a896f46ea28875b5c28c94996ffd3a7b12f Mon Sep 17 00:00:00 2001 From: David Bremner Date: Sun, 14 Aug 2016 09:22:09 +0900 Subject: [PATCH] Re: [PATCH v4 12/16] add --try-decrypt to notmuch new --- 09/3c9376a873c35b35cf28093a39b03dd2a3438b | 81 +++++++++++++++++++++++ 1 file changed, 81 insertions(+) create mode 100644 09/3c9376a873c35b35cf28093a39b03dd2a3438b diff --git a/09/3c9376a873c35b35cf28093a39b03dd2a3438b b/09/3c9376a873c35b35cf28093a39b03dd2a3438b new file mode 100644 index 000000000..38d7979e1 --- /dev/null +++ b/09/3c9376a873c35b35cf28093a39b03dd2a3438b @@ -0,0 +1,81 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id E887B6DE4F43 + for ; Sat, 13 Aug 2016 17:43:01 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.007 +X-Spam-Level: +X-Spam-Status: No, score=-0.007 tagged_above=-999 required=5 tests=[AWL=0.004, + SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id D3ADGX0Zk4fU for ; + Sat, 13 Aug 2016 17:42:54 -0700 (PDT) +Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) + by arlo.cworth.org (Postfix) with ESMTPS id 333846DE4F51 + for ; Sat, 13 Aug 2016 17:22:13 -0700 (PDT) +Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2) + (envelope-from ) + id 1bYjC5-00053C-AC; Sat, 13 Aug 2016 20:22:25 -0400 +Received: (nullmailer pid 31070 invoked by uid 1000); + Sun, 14 Aug 2016 00:22:09 -0000 +From: David Bremner +To: Daniel Kahn Gillmor , + Notmuch Mail +Subject: Re: [PATCH v4 12/16] add --try-decrypt to notmuch new +In-Reply-To: <1467970047-8013-13-git-send-email-dkg@fifthhorseman.net> +References: <1467970047-8013-1-git-send-email-dkg@fifthhorseman.net> + <1467970047-8013-13-git-send-email-dkg@fifthhorseman.net> +User-Agent: Notmuch/0.22.1+61~g2ce0f13 (https://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Sun, 14 Aug 2016 09:22:09 +0900 +Message-ID: <87y44042tq.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 14 Aug 2016 00:43:02 -0000 + +Daniel Kahn Gillmor writes: + +> Try to decrypt any encrypted parts of newly-discovered messages while +> indexing them. The cleartext of any successfully-decrypted messages +> will be indexed, with tags applied in the same form as from notmuch +> insert --try-decrypt. + +s/tags/properties/? At this point I'm a bit lost, and not sure where +those properties are documented, but this commit message is a bit +strange since it kindof implies the reader is likely to know what those +are. + +> diff --git a/notmuch-new.c b/notmuch-new.c +> index c55dea7..e495557 100644 +> --- a/notmuch-new.c +> +++ b/notmuch-new.c +> @@ -49,6 +49,7 @@ typedef struct { +> size_t new_tags_length; +> const char **new_ignore; +> size_t new_ignore_length; +> + notmuch_indexopts_t *indexopts; + +I'm only reading the patch here, but is this variable actually used? + +> int total_files; +> int processed_files; +> @@ -260,7 +261,8 @@ add_file (notmuch_database_t *notmuch, const char *filename, +> if (status) +> goto DONE; + -- 2.26.2