From e83127dee8e6994904b85f7b8b3a30b6238fec7c Mon Sep 17 00:00:00 2001 From: Jeffrey Altman Date: Thu, 21 Sep 2006 02:43:12 +0000 Subject: [PATCH] windows thread support frees thread local storage after TlsSetValue threads.c: The return value of TlsSetValue is non-zero on success. As a result of misinterpreting the return value, the memory set in TLS is then freed. A subsequent call to TlsGetValue returns the invalid pointer. ticket: new tags: pullup git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18600 dc483132-0cff-0310-8789-dd5450dbe970 --- src/util/support/threads.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/support/threads.c b/src/util/support/threads.c index ebc1dafae..7693cbb53 100644 --- a/src/util/support/threads.c +++ b/src/util/support/threads.c @@ -275,9 +275,9 @@ int k5_setspecific (k5_key_t keynum, void *value) /* add to global linked list */ /* t->next = 0; */ err = TlsSetValue(tls_idx, t); - if (err) { + if (!err) { free(t); - return err; + return GetLastError(); } } -- 2.26.2